diff options
| author | Harald Welte <laforge@gnumonks.org> | 2018-05-27 11:53:43 +0200 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2018-05-27 20:17:06 +0200 |
| commit | 1876c3108ca5c07587bae4c23217579618f77331 (patch) | |
| tree | 5dcc45f764f67b348420ff91be7e4c64c6c5e25e /src/osmo-bsc | |
| parent | 68e4be9c845e25f53aea511b1c57340a9da5825c (diff) | |
move 'extern struct gsm_network *bsc_gsmnet" to header file
It's not a good idea to keep extern declarations copied over
half a dozen C files. Let's move it to a header.
Change-Id: I6f643f1393ba0955d9c0cf1cf78d5c604e7b9451
Diffstat (limited to 'src/osmo-bsc')
| -rw-r--r-- | src/osmo-bsc/osmo_bsc_ctrl.c | 2 | ||||
| -rw-r--r-- | src/osmo-bsc/osmo_bsc_sigtran.c | 5 | ||||
| -rw-r--r-- | src/osmo-bsc/osmo_bsc_vty.c | 2 |
3 files changed, 2 insertions, 7 deletions
diff --git a/src/osmo-bsc/osmo_bsc_ctrl.c b/src/osmo-bsc/osmo_bsc_ctrl.c index 7891cf427..13cf98dce 100644 --- a/src/osmo-bsc/osmo_bsc_ctrl.c +++ b/src/osmo-bsc/osmo_bsc_ctrl.c @@ -41,8 +41,6 @@ #include <time.h> #include <unistd.h> -extern struct gsm_network *bsc_gsmnet; - /* Obtain SS7 application server currently handling given MSC (DPC) */ static struct osmo_ss7_as *msc_get_ss7_as(struct bsc_msc_data *msc) { diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index c33124f70..608c3fbca 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -1,5 +1,5 @@ /* (C) 2017 by sysmocom s.f.m.c. GmbH, Author: Philipp Maier - * (C) 2017 by Harald Welte <laforge@gnumonks.org> + * (C) 2017-2018 by Harald Welte <laforge@gnumonks.org> * All Rights Reserved * * This program is free software; you can redistribute it and/or modify @@ -34,13 +34,12 @@ #include <osmocom/bsc/a_reset.h> #include <osmocom/bsc/gsm_04_80.h> #include <osmocom/bsc/bsc_subscr_conn_fsm.h> +#include <osmocom/bsc/gsm_data.h> /* A pointer to a list with all involved MSCs * (a copy of the pointer location submitted with osmo_bsc_sigtran_init() */ static struct llist_head *msc_list; -extern struct gsm_network *bsc_gsmnet; - #define RESET_INTERVAL 1 /* sek */ #define SCCP_MSG_MAXSIZE 1024 #define CS7_POINTCODE_DEFAULT_OFFSET 2 diff --git a/src/osmo-bsc/osmo_bsc_vty.c b/src/osmo-bsc/osmo_bsc_vty.c index d1a82ba92..34080c0d1 100644 --- a/src/osmo-bsc/osmo_bsc_vty.c +++ b/src/osmo-bsc/osmo_bsc_vty.c @@ -38,8 +38,6 @@ #define IPA_STR "IP.ACCESS specific\n" -extern struct gsm_network *bsc_gsmnet; - static struct osmo_bsc_data *osmo_bsc_data(struct vty *vty) { return bsc_gsmnet->bsc_data; |