diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2020-05-22 01:08:26 +0200 |
|---|---|---|
| committer | neels <nhofmeyr@sysmocom.de> | 2020-05-29 20:16:40 +0000 |
| commit | 6a8955b741f50afd39e9471c026fe15abc858762 (patch) | |
| tree | e47600732a8a8bdc8a343c7816a2e5bc8fce735a /src/osmo-bsc/osmo_bsc_sigtran.c | |
| parent | dbc7a3c9b995a18b1c4cc76335936a8aa4feb4ec (diff) | |
drop all BSC originated USSD notification features
The BSC is the wrong network component to originate USSD messaging, as can be
seen in the hacks in the USSD code: for example, the BSC would send a CM
Service Accept message as if an MSC had accepted the connection, dispatch a
USSD and directly send some RR release message (without proper tear down
messaging like the lchan_fsm does these days). This made sense in the osmo-nitb
world, but by now we are aiming for solid 3GPP compliance. The BSC shall not
originate USSD messages.
Deprecate all VTY and CTRL commands related to USSD:
VTY
[no] bsc-welcome-text
[no] bsc-msc-lost-text
[no] bsc-grace-text
[no] missing-msc-text
(the commands with 'no' are ignored, without 'no' lead to an error)
CTRL
ussd-notify-v1
Drop (already unused) ussd.h.
Drop gsm_04_80.h, gsm_04_80_utils.c, and all calling code.
Drop "RF grace" notification, where osmo-bsc was able to notify active
subscribers that the RF was being turned off.
Change-Id: Iaef6f2e01b4dbf2bff0a0bb50d6851f50ae79f6a
Diffstat (limited to 'src/osmo-bsc/osmo_bsc_sigtran.c')
| -rw-r--r-- | src/osmo-bsc/osmo_bsc_sigtran.c | 22 |
1 files changed, 0 insertions, 22 deletions
diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index d36c85dd9..cbf0fec1a 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -32,7 +32,6 @@ #include <osmocom/bsc/osmo_bsc_grace.h> #include <osmocom/bsc/osmo_bsc_sigtran.h> #include <osmocom/bsc/a_reset.h> -#include <osmocom/bsc/gsm_04_80.h> #include <osmocom/bsc/bsc_subscr_conn_fsm.h> #include <osmocom/bsc/gsm_data.h> #include <osmocom/mgcp_client/mgcp_common.h> @@ -426,24 +425,6 @@ int osmo_bsc_sigtran_send(struct gsm_subscriber_connection *conn, struct msgb *m return rc; } -/* Send an USSD notification in case we loose the connection to the MSC */ -static void bsc_notify_msc_lost(struct gsm_subscriber_connection *conn) -{ - /* Check if sccp conn is still present */ - if (!conn) - return; - - /* check for config string */ - if (!conn->sccp.msc->ussd_msc_lost_txt) - return; - if (conn->sccp.msc->ussd_msc_lost_txt[0] == '\0') - return; - - /* send USSD notification */ - bsc_send_ussd_notify(conn, 1, conn->sccp.msc->ussd_msc_lost_txt); - bsc_send_ussd_release_complete(conn); -} - /* Close all open sigtran connections and channels */ void osmo_bsc_sigtran_reset(const struct bsc_msc_data *msc) { @@ -456,9 +437,6 @@ void osmo_bsc_sigtran_reset(const struct bsc_msc_data *msc) /* We only may close connections which actually belong to this * MSC. All other open connections are left untouched */ if (conn->sccp.msc == msc) { - /* Notify active connection users via USSD that the MSC is down */ - bsc_notify_msc_lost(conn); - /* Take down all occopied RF channels */ /* Disconnect all Sigtran connections */ /* Delete subscriber connection */ |