diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2020-05-22 01:08:26 +0200 |
|---|---|---|
| committer | neels <nhofmeyr@sysmocom.de> | 2020-05-29 20:16:40 +0000 |
| commit | 6a8955b741f50afd39e9471c026fe15abc858762 (patch) | |
| tree | e47600732a8a8bdc8a343c7816a2e5bc8fce735a /src/osmo-bsc/osmo_bsc_filter.c | |
| parent | dbc7a3c9b995a18b1c4cc76335936a8aa4feb4ec (diff) | |
drop all BSC originated USSD notification features
The BSC is the wrong network component to originate USSD messaging, as can be
seen in the hacks in the USSD code: for example, the BSC would send a CM
Service Accept message as if an MSC had accepted the connection, dispatch a
USSD and directly send some RR release message (without proper tear down
messaging like the lchan_fsm does these days). This made sense in the osmo-nitb
world, but by now we are aiming for solid 3GPP compliance. The BSC shall not
originate USSD messages.
Deprecate all VTY and CTRL commands related to USSD:
VTY
[no] bsc-welcome-text
[no] bsc-msc-lost-text
[no] bsc-grace-text
[no] missing-msc-text
(the commands with 'no' are ignored, without 'no' lead to an error)
CTRL
ussd-notify-v1
Drop (already unused) ussd.h.
Drop gsm_04_80.h, gsm_04_80_utils.c, and all calling code.
Drop "RF grace" notification, where osmo-bsc was able to notify active
subscribers that the RF was being turned off.
Change-Id: Iaef6f2e01b4dbf2bff0a0bb50d6851f50ae79f6a
Diffstat (limited to 'src/osmo-bsc/osmo_bsc_filter.c')
| -rw-r--r-- | src/osmo-bsc/osmo_bsc_filter.c | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/src/osmo-bsc/osmo_bsc_filter.c b/src/osmo-bsc/osmo_bsc_filter.c index b4985f286..98b51485c 100644 --- a/src/osmo-bsc/osmo_bsc_filter.c +++ b/src/osmo-bsc/osmo_bsc_filter.c @@ -21,7 +21,6 @@ #include <osmocom/bsc/osmo_bsc.h> #include <osmocom/bsc/bsc_msc_data.h> -#include <osmocom/bsc/gsm_04_80.h> #include <osmocom/bsc/gsm_04_08_rr.h> #include <osmocom/bsc/bsc_subscriber.h> #include <osmocom/bsc/debug.h> @@ -30,16 +29,6 @@ #include <stdlib.h> -static int send_welcome_ussd(struct gsm_subscriber_connection *conn) -{ - if (!conn->sccp.msc->ussd_welcome_txt) { - LOGP(DMSC, LOGL_DEBUG, "No USSD Welcome text defined.\n"); - return 0; - } - - return BSS_SEND_USSD; -} - static int bsc_patch_mm_info(struct gsm_subscriber_connection *conn, uint8_t *data, unsigned int length) { @@ -150,9 +139,6 @@ int bsc_scan_msc_msg(struct gsm_subscriber_connection *conn, struct msgb *msg) gsm48_generate_lai2(lai, bts_lai(conn_get_bts(conn))); } } - - if (conn->new_subscriber) - return send_welcome_ussd(conn); return 0; } else if (mtype == GSM48_MT_MM_INFO) { bsc_patch_mm_info(conn, &gh->data[0], length); |