diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2021-07-08 06:20:46 +0200 |
|---|---|---|
| committer | laforge <laforge@osmocom.org> | 2021-07-16 16:04:18 +0000 |
| commit | ae0b737c62e4f8953dc64b67515fff5f2b330fea (patch) | |
| tree | 8b34928a8b443fddede661758a19d9359d07cc6a /src/osmo-bsc/nm_bts_fsm.c | |
| parent | 71b4f94601cbd1aa97729be2d789d21d20aea706 (diff) | |
separate 'interference-meas level-bounds' cfg and used
The VTY defun already indicates BSC_VTY_ATTR_RESTART_ABIS_OML_LINK
correctly, but so far we would immediately start using the new values
internally, and wrongly interpret interference levels. Fix that.
Have bts->interf_meas_params twice: interf_meas_params_cfg for the VTY
configured values, and interf_meas_params_used for the values that the
BTS actually knows about, after they were sent via OML.
In a running BSC, when changing the interference level boundaries on the
telnet VTY, the BTS is not immediately told about the change. That would
require a BTS restart. Hence store the cfg values separately in
interf_meas_params_cfg. For comparing/printing interference levels in a
running BTS, only employ the values that were actually sent via OML and
placed in interf_meas_params_used.
Related: SYS#5313
Change-Id: Iad8cf4151ff7f86dc0549158ed5d91d788d40b1f
Diffstat (limited to 'src/osmo-bsc/nm_bts_fsm.c')
| -rw-r--r-- | src/osmo-bsc/nm_bts_fsm.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/osmo-bsc/nm_bts_fsm.c b/src/osmo-bsc/nm_bts_fsm.c index 329d91190..eda74fd5a 100644 --- a/src/osmo-bsc/nm_bts_fsm.c +++ b/src/osmo-bsc/nm_bts_fsm.c @@ -116,6 +116,9 @@ static void configure_loop(struct gsm_bts *bts, struct gsm_nm_state *state, bool abis_nm_chg_adm_state(bts, NM_OC_BTS, bts->bts_nr, 0xff, 0xff, NM_STATE_UNLOCKED); + /* Message containing BTS attributes, including the interference band bounds, was ACKed by the BTS. + * Store the sent bounds as the ones being used for logging and comparing intereference levels. */ + bts->interf_meas_params_used = bts->interf_meas_params_cfg; } if (allow_opstart && state->administrative == NM_STATE_UNLOCKED && |