dissolve libbsc: move all to src/osmo-bsc, link .o files

Move all of libbsc/ into osmo-bsc/, and separate/move some implementations to
allow linking from utils/* and ipaccess/* without pulling in unccessary
dependencies.

Some utilities use gsm_network and gsm_bts structs, which already include data
structures for fairly advanced uses. Move initialization that only osmo-bsc
needs into new bsc_network_init() and bsc_bts_alloc_register() functions, so
that the leaner tools can use the old gsm_* versions without the need to link
everything (e.g. handover and lchan alloc code).

In some instances, there need to be stubs if to cut off linking "just before
the RSL level" and prevent dependencies from creeping in.
- abis_rsl_rcvmsg(): the only program currently interpreting RSL messages is
  osmo-bsc, the utils are merely concerned with OML, if at all.
- paging_flush_bts(): ip.access nanobts models call this when the RSL link is
  dropped. Only osmo-bsc actually needs to do anything there.
- on_gsm_ts_init(): the mechanism to trigger timeslot initialization is related
  to OML, while this action to take on init would pull in RSL dependencies.
utils/ and ipaccess/ each have a stubs.c file to implement these stubs. Tests
implement stubs inline where required.

From src/utils/, src/ipaccess/ and tests/*/, link in .o files from osmo-bsc/.
In order for this to work, the osmo-bsc subdir must be built before the other
source trees. (An alternative would be to include the .c files as sources, but
that would re-compile them in every source tree. Not a large burden really, but
unless linking .o files gives problems, let's have the quicker build.)

Minor obvious cleanups creep in with this patch, I will not bother to name them
individually now unless code review asks me to.

Rationale:

1) libbsc has been separate to use it for osmo-nitb and osmo-bsc in the old
openbsc.git. This is no longer required, and spreading over libbsc and osmo-bsc
is distracting.

2) Recently, ridiculous linking requirements have made adding new functions
cumbersome, because libbsc has started depending on osmo-bsc/*.c
implementations: on gscon FSM and bssap functions. For example, neither
bs11_config nor ipaccess-config nor bts_test need handover_cfg or BSSMAP
message composition. It makes no sense to link the entire osmo-bsc to it, nor
do we want to keep adding stubs to each linking realm.

Change-Id: I36a586726f5818121abe54d25654819fc451d3bf

1 files changed, 177 insertions, 0 deletions

diff --git a/src/osmo-bsc/handover_vty.c b/src/osmo-bsc/handover_vty.c
new file mode 100644
index 000000000..51e448e03
--- /dev/null
+++ b/src/osmo-bsc/handover_vty.c
@@ -0,0 +1,177 @@
+/* OsmoBSC interface to quagga VTY for handover parameters */
+/* (C) 2009-2010 by Andreas Eversberg <jolly@eversberg.eu>
+ * (C) 2009-2010 by Harald Welte <laforge@gnumonks.org>
+ * (C) 2017-2018 by sysmocom - s.f.m.c. GmbH <info@sysmocom.de>
+ *
+ * All Rights Reserved
+ *
+ * Author: Andreas Eversberg <jolly@eversberg.eu>
+ *         Neels Hofmeyr <nhofmeyr@sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#include <osmocom/bsc/gsm_data.h>
+#include <osmocom/bsc/vty.h>
+#include <osmocom/bsc/handover_cfg.h>
+#include <osmocom/bsc/handover_decision_2.h>
+
+static struct handover_cfg *ho_cfg_from_vty(struct vty *vty)
+{
+	switch (vty->node) {
+	case GSMNET_NODE:
+		return gsmnet_from_vty(vty)->ho;
+	case BTS_NODE:
+		OSMO_ASSERT(vty->index);
+		return ((struct gsm_bts *)vty->index)->ho;
+	default:
+		OSMO_ASSERT(false);
+	}
+}
+
+
+#define HO_CFG_ONE_MEMBER(TYPE, NAME, DEFAULT_VAL, \
+			  VTY_CMD_PREFIX, VTY_CMD, VTY_CMD_ARG, VTY_ARG_EVAL, \
+			  VTY_WRITE_FMT, VTY_WRITE_CONV, \
+			  VTY_DOC) \
+DEFUN(cfg_ho_##NAME, cfg_ho_##NAME##_cmd, \
+      VTY_CMD_PREFIX VTY_CMD " (" VTY_CMD_ARG "|default)", \
+      VTY_DOC \
+      "Use default (" #DEFAULT_VAL "), remove explicit setting on this node\n") \
+{ \
+	struct handover_cfg *ho = ho_cfg_from_vty(vty); \
+	const char *val = argv[0]; \
+	if (!strcmp(val, "default")) { \
+		const char *msg; \
+		if (ho_isset_##NAME(ho)) {\
+			ho_clear_##NAME(ho); \
+			msg = "setting removed, now is"; \
+		} else \
+			msg = "already was unset, still is"; \
+		vty_out(vty, "%% '" VTY_CMD_PREFIX VTY_CMD "' %s " VTY_WRITE_FMT "%s%s", \
+			msg, VTY_WRITE_CONV( ho_get_##NAME(ho) ), \
+			ho_isset_on_parent_##NAME(ho)? " (set on higher level node)" : "", \
+			VTY_NEWLINE); \
+	} \
+	else \
+		ho_set_##NAME(ho, VTY_ARG_EVAL(val)); \
+	return CMD_SUCCESS; \
+}
+
+HO_CFG_ALL_MEMBERS
+#undef HO_CFG_ONE_MEMBER
+
+
+/* Aliases of 'handover' for 'handover1' for backwards compat */
+#define HO_CFG_ONE_MEMBER(TYPE, NAME, DEFAULT_VAL, \
+			  VTY_CMD_PREFIX, VTY_CMD, VTY_CMD_ARG, VTY_ARG_EVAL, \
+			  VTY_WRITE_FMT, VTY_WRITE_CONV, \
+			  VTY_DOC) \
+ALIAS_DEPRECATED(cfg_ho_##NAME, cfg_ho_##NAME##_cmd_alias, \
+      "handover " VTY_CMD " (" VTY_CMD_ARG "|default)", \
+      "Legacy alias for 'handover1': " VTY_DOC \
+      "Use default (" #DEFAULT_VAL "), remove explicit setting on this node\n");
+
+HODEC1_CFG_ALL_MEMBERS
+#undef HO_CFG_ONE_MEMBER
+
+static inline const int a2congestion_check_interval(const char *arg)
+{
+	if (!strcmp(arg, "disabled"))
+		return 0;
+	return atoi(arg);
+}
+
+static inline const char *congestion_check_interval2a(int val)
+{
+	static char str[9];
+	if (val < 1
+	    || snprintf(str, sizeof(str), "%d", val) >= sizeof(str))
+		return "disabled";
+	return str;
+}
+
+DEFUN(cfg_net_ho_congestion_check_interval, cfg_net_ho_congestion_check_interval_cmd,
+      "handover2 congestion-check (disabled|<1-999>|now)",
+      HO_CFG_STR_HANDOVER2
+      "Configure congestion check interval" HO_CFG_STR_2
+      "Disable congestion checking, do not handover based on cell overload\n"
+      "Congestion check interval in seconds (default "
+      OSMO_STRINGIFY_VAL(HO_CFG_CONGESTION_CHECK_DEFAULT) ")\n"
+      "Manually trigger a congestion check to run right now\n")
+{
+	if (!strcmp(argv[0], "now")) {
+		hodec2_congestion_check(gsmnet_from_vty(vty));
+		return CMD_SUCCESS;
+	}
+
+	hodec2_on_change_congestion_check_interval(gsmnet_from_vty(vty),
+								a2congestion_check_interval(argv[0]));
+	return CMD_SUCCESS;
+}
+
+static void ho_vty_write(struct vty *vty, const char *indent, struct handover_cfg *ho)
+{
+#define HO_CFG_ONE_MEMBER(TYPE, NAME, DEFAULT_VAL, \
+			  VTY_CMD_PREFIX, VTY_CMD, VTY_CMD_ARG, VTY_ARG_EVAL, \
+			  VTY_WRITE_FMT, VTY_WRITE_CONV, \
+			  VTY_DOC) \
+	if (ho_isset_##NAME(ho)) \
+		vty_out(vty, "%s" VTY_CMD_PREFIX VTY_CMD " " VTY_WRITE_FMT "%s", indent, \
+			VTY_WRITE_CONV( ho_get_##NAME(ho) ), VTY_NEWLINE);
+
+	HO_CFG_ALL_MEMBERS
+#undef HO_CFG_ONE_MEMBER
+}
+
+void ho_vty_write_bts(struct vty *vty, struct gsm_bts *bts)
+{
+	ho_vty_write(vty, "  ", bts->ho);
+}
+
+void ho_vty_write_net(struct vty *vty, struct gsm_network *net)
+{
+	ho_vty_write(vty, " ", net->ho);
+
+	if (net->hodec2.congestion_check_interval_s != HO_CFG_CONGESTION_CHECK_DEFAULT)
+		vty_out(vty, " handover2 congestion-check %s%s",
+			congestion_check_interval2a(net->hodec2.congestion_check_interval_s),
+			VTY_NEWLINE);
+}
+
+static void ho_vty_init_cmds(int parent_node)
+{
+#define HO_CFG_ONE_MEMBER(TYPE, NAME, DEFAULT_VAL, VTY0, VTY1, VTY2, VTY3, VTY4, VTY5, VTY6) \
+	install_element(parent_node, &cfg_ho_##NAME##_cmd);
+
+	HO_CFG_ALL_MEMBERS
+#undef HO_CFG_ONE_MEMBER
+
+	/* Aliases of 'handover' for 'handover1' for backwards compat */
+#define HO_CFG_ONE_MEMBER(TYPE, NAME, DEFAULT_VAL, VTY0, VTY1, VTY2, VTY3, VTY4, VTY5, VTY6) \
+	install_element(parent_node, &cfg_ho_##NAME##_cmd_alias);
+
+HODEC1_CFG_ALL_MEMBERS
+#undef HO_CFG_ONE_MEMBER
+}
+
+void ho_vty_init()
+{
+	ho_vty_init_cmds(GSMNET_NODE);
+	install_element(GSMNET_NODE, &cfg_net_ho_congestion_check_interval_cmd);
+
+	ho_vty_init_cmds(BTS_NODE);
+}
+