diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2021-07-08 18:28:20 +0200 |
|---|---|---|
| committer | neels <nhofmeyr@sysmocom.de> | 2021-07-15 09:28:18 +0000 |
| commit | 71526043ea042fbad65b3a099e94190fc086640c (patch) | |
| tree | c72eb0562bc399de6ccfe8000262a7c172e4a0eb /src/osmo-bsc/handover_decision_2.c | |
| parent | fdb87343d7a747575fae0bb436cd9d105b9748e9 (diff) | |
ensure trigger_ho() returns zero only when HO or AS was indeed triggered
In an upcoming patch, handover_decision_2.c will use this indicator to
decide whether to start a penalty timer:
"hodec2: add low-rxqual-assignment penalty timer (2/2)"
Id00a07313fe04eec509b336c0637b59c707760e0
Related: SYS#5198
Change-Id: I5de385e0666f716184a62e6e70d656545ac5d2ee
Diffstat (limited to 'src/osmo-bsc/handover_decision_2.c')
| -rw-r--r-- | src/osmo-bsc/handover_decision_2.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c index 3fa1084e4..af36c3189 100644 --- a/src/osmo-bsc/handover_decision_2.c +++ b/src/osmo-bsc/handover_decision_2.c @@ -854,7 +854,7 @@ static int trigger_local_ho_or_as(struct ho_candidate *c, uint8_t requirements) if ((requirements & REQUIREMENT_TCHF_MASK)) { if (c->current.bts == c->target.bts) { LOGPHOLCHAN(c->current.lchan, LOGL_INFO, "Not performing assignment: Already on target type\n"); - return 0; + return -EALREADY; } full_rate = true; break; @@ -886,7 +886,7 @@ static int trigger_local_ho_or_as(struct ho_candidate *c, uint8_t requirements) } if (c->current.bts == c->target.bts) { LOGPHOLCHAN(c->current.lchan, LOGL_INFO, "Not performing assignment: Already on target type\n"); - return 0; + return -EALREADY; } break; default: @@ -899,8 +899,8 @@ static int trigger_local_ho_or_as(struct ho_candidate *c, uint8_t requirements) LOGPHOLCHAN(c->current.lchan, LOGL_NOTICE, "Triggering assignment to %s, due to %s\n", full_rate ? "TCH/F" : "TCH/H", ho_reason_name(global_ho_reason)); - reassignment_request_to_chan_type(ASSIGN_FOR_CONGESTION_RESOLUTION, c->current.lchan, - full_rate? GSM_LCHAN_TCH_F : GSM_LCHAN_TCH_H); + return reassignment_request_to_chan_type(ASSIGN_FOR_CONGESTION_RESOLUTION, c->current.lchan, + full_rate? GSM_LCHAN_TCH_F : GSM_LCHAN_TCH_H); } else { struct handover_out_req req = { .from_hodec_id = HODEC2, |