diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2021-03-09 17:11:45 +0100 |
|---|---|---|
| committer | Neels Hofmeyr <neels@hofmeyr.de> | 2021-03-24 21:22:21 +0100 |
| commit | 764449ec2ea6d6b45239278eae90613df8c93f59 (patch) | |
| tree | f25eeef115083e20eaa7c4713b18d1889e7b865e /src/osmo-bsc/handover_decision.c | |
| parent | dc60505bc585b1d5f61aa7190b3a2f14fecacaa1 (diff) | |
fix/refactor neighbor config
The neighbor configuration storage is fundamentally broken: it requires
all local cells to be configured before being able to list them as
neighbors of each other. Upon config write-back, the neighbor config
however is placed back inline with the other config, and hence a
written-out neighbor config no longer works on program restart.
The cause of this problem is that the config is stored as explicit
pointers between local cells (struct gsm_bts), which of course requires
the pointer to exist before being able to reference it.
Instead, store the actual configuration that the user entered as-is,
without pointers or references to objects that need to be ready. Resolve
the neighbors every time a neighbor is needed.
Hence the user may enter any config at any place in the config file,
even non-working config (like a BTS number that doesn't exist), and the
relation to actual local or remote neighbor cells is made at runtime.
Abort program startup if the initial neighbor configuration contains
errors.
Related: OS#5018
Change-Id: I9ed992f8bfff888b3933733c0576f92d50f2625b
Diffstat (limited to 'src/osmo-bsc/handover_decision.c')
| -rw-r--r-- | src/osmo-bsc/handover_decision.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/osmo-bsc/handover_decision.c b/src/osmo-bsc/handover_decision.c index 7eb8f31e0..1eeb277ff 100644 --- a/src/osmo-bsc/handover_decision.c +++ b/src/osmo-bsc/handover_decision.c @@ -201,8 +201,7 @@ static void attempt_handover(struct gsm_meas_rep *mr) req = (struct handover_out_req){ .from_hodec_id = HODEC1, .old_lchan = mr->lchan, - .target_nik = { - .from_bts = bts->nr, + .target_cell_ab = { .arfcn = best_cell->arfcn, .bsic = best_cell->bsic, }, |