diff options
| author | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2020-12-24 00:54:41 +0100 |
|---|---|---|
| committer | laforge <laforge@osmocom.org> | 2020-12-27 12:56:34 +0000 |
| commit | f4674e3f7a5ee8f86003890bf662364ae3c71357 (patch) | |
| tree | d2db257ff7e1014dc03625070812587c33887bb8 /src/osmo-bsc/gsm_data.c | |
| parent | 06b8a78e61425b7f05ae3dbd3c0b3166714a9eb9 (diff) | |
power_control: fix swapped lower/upper RxQual threshold values
According to 3GPP TS 45.008, section A.3.2.1:
c) Comparison of RXQUAL_XX with L_RXQUAL_XX_P (XX = DL or UL):
Increase XX_TXPWR if at least P3 averaged values out of N3
averaged values are greater (worse quality) than L_RXQUAL_XX_P.
d) Comparison of RXQUAL_XX with U_RXQUAL_XX_P (XX = DL or UL):
Decrease XX_TXPWR if at least P4 averaged values out of N4
averaged values are lower (better quality) than U_RXQUAL_XX_P.
Given that RxQual is a value in range 0 .. 7, where 0 is the best
and 7 is the worst: L_RXQUAL_XX_P must define the worst quality,
while U_RXQUAL_XX_P must define the best quality value.
Change-Id: I0f37b23ed360782f3c1f4275234c4e18a17aa89b
Related: SYS#4918
Diffstat (limited to 'src/osmo-bsc/gsm_data.c')
| -rw-r--r-- | src/osmo-bsc/gsm_data.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 4c87fd874..38392fc1e 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -1007,8 +1007,8 @@ const struct gsm_power_ctrl_params power_ctrl_params_def = { /* RxQual measurement parameters */ .rxqual_meas = { /* Thresholds for RxQual (see 3GPP TS 45.008, A.3.2.1) */ - .lower_thresh = 0, /* L_RXQUAL_XX_P (BER < 0.2%) */ - .upper_thresh = 3, /* U_RXQUAL_XX_P (0.8% <= BER < 1.6%) */ + .lower_thresh = 3, /* L_RXQUAL_XX_P (0.8% <= BER < 1.6%) */ + .upper_thresh = 0, /* U_RXQUAL_XX_P (BER < 0.2%) */ /* Increase {UL,DL}_TXPWR if at least LOWER_CMP_P averages * out of LOWER_CMP_N averages are lower than L_RXLEV_XX_P */ |