diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2021-07-08 06:20:46 +0200 |
|---|---|---|
| committer | laforge <laforge@osmocom.org> | 2021-07-16 16:04:18 +0000 |
| commit | ae0b737c62e4f8953dc64b67515fff5f2b330fea (patch) | |
| tree | 8b34928a8b443fddede661758a19d9359d07cc6a /src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c | |
| parent | 71b4f94601cbd1aa97729be2d789d21d20aea706 (diff) | |
separate 'interference-meas level-bounds' cfg and used
The VTY defun already indicates BSC_VTY_ATTR_RESTART_ABIS_OML_LINK
correctly, but so far we would immediately start using the new values
internally, and wrongly interpret interference levels. Fix that.
Have bts->interf_meas_params twice: interf_meas_params_cfg for the VTY
configured values, and interf_meas_params_used for the values that the
BTS actually knows about, after they were sent via OML.
In a running BSC, when changing the interference level boundaries on the
telnet VTY, the BTS is not immediately told about the change. That would
require a BTS restart. Hence store the cfg values separately in
interf_meas_params_cfg. For comparing/printing interference levels in a
running BTS, only employ the values that were actually sent via OML and
placed in interf_meas_params_used.
Related: SYS#5313
Change-Id: Iad8cf4151ff7f86dc0549158ed5d91d788d40b1f
Diffstat (limited to 'src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c')
| -rw-r--r-- | src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index ed3a80212..aac0ddfd1 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -37,10 +37,10 @@ struct msgb *nanobts_attr_bts_get(struct gsm_bts *bts) /* Interference level Boundaries: 0 .. X5 (3GPP TS 52.021, section 9.4.25) */ msgb_tv_fixed_put(msgb, NM_ATT_INTERF_BOUND, - sizeof(bts->interf_meas_params.bounds_dbm), - &bts->interf_meas_params.bounds_dbm[0]); + sizeof(bts->interf_meas_params_cfg.bounds_dbm), + &bts->interf_meas_params_cfg.bounds_dbm[0]); /* Intave: Interference Averaging period (3GPP TS 52.021, section 9.4.24) */ - msgb_tv_put(msgb, NM_ATT_INTAVE_PARAM, bts->interf_meas_params.avg_period); + msgb_tv_put(msgb, NM_ATT_INTAVE_PARAM, bts->interf_meas_params_cfg.avg_period); rlt = gsm_bts_get_radio_link_timeout(bts); if (rlt == -1) { |