diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2021-06-04 17:53:37 +0200 |
|---|---|---|
| committer | laforge <laforge@osmocom.org> | 2021-06-05 15:48:53 +0000 |
| commit | 4d5604ad92e1ffd09efde2180feb94b6620ceace (patch) | |
| tree | 4a492f741152b8ac8673f5110385a8fc52c8b1de /src/osmo-bsc/abis_rsl.c | |
| parent | 245465662e14109ca6797707308bf5f7634e2ef0 (diff) | |
fixup: pass tsc = -1 for previous default training sequence code
An unintended change in default behavior was introduced in patch:
"allow explixit TSC Set and TSC on chan activ / modif / assignment"
Ic665125255d7354f5499d10dda1dd866ab243d24
c33eb8d56943b8981523754b081967e6ff5f245d
Set tsc_set and tsc = -1 for all lchan_activate_info and
assignment_request requests to actually yield the default behavior of
selecting the TSC based on the timeslot cfg or the BSIC value.
By setting tsc = 0 implicitly, the patch caused all requests to ask for
tsc 0 instead of calling gsm_ts_tsc().
For a Channel Mode Modify in assignment_fsm, pass the lchan's current
TSC to keep it unchanged.
osmo-ttcn3-hacks Id67a949e0f61ec8123976eb8d336f04510c55c01 adds a test
to verify the expected TSC in all of the activation, assignment and
modify messages. Current osmo-bsc master fails, this patch fixes.
Related: SYS#5315 OS#4940 Ic665125255d7354f5499d10dda1dd866ab243d24
Change-Id: If12df11511fe22ea167782f776736a1a9c484b1f
Diffstat (limited to 'src/osmo-bsc/abis_rsl.c')
| -rw-r--r-- | src/osmo-bsc/abis_rsl.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index fc8e217c6..69052ee67 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1807,6 +1807,8 @@ void abis_rsl_chan_rqd_queue_poll(struct gsm_bts *bts) }, .ta = rqd->ta, .ta_known = true, + .tsc_set = -1, + .tsc = -1, }; lchan_activate(lchan, &info); |