diff options
| author | Harald Welte <laforge@gnumonks.org> | 2017-07-20 01:47:39 +0200 |
|---|---|---|
| committer | Neels Hofmeyr <neels@hofmeyr.de> | 2017-08-27 03:52:46 +0200 |
| commit | a0d324b3d01306e7ca9f663f06a5ccb7342b6459 (patch) | |
| tree | 5c1d383fdee365d97b89642b877b0efa4a51cbc4 /src/libbsc/net_init.c | |
| parent | b71147a47f663582aa241c4f25f71f3bbaeaf351 (diff) | |
GSM timers: User reasonable defaults; don't save if equal default
A number of the GSM timers (including T3109) had no reasonable
default values if not specified in the VTY / config file. Together
with unconditional writing to the config file, this created
config files with a persistent setting for important timers as '0'.
To make things worse, many of our example cofig files suffered from the
same problem.
Let's avoid this from happening by
* having reasonable defaults if nothing specified in the config file
* conditionally savingg timers only if they differ from default
* reject any timer values that state zero during start-up (see previous
commit)
Change-Id: Iaac0bfca423852b61d8b9eb1438157ef00d0d8c8
Closes: OS#2380
Diffstat (limited to 'src/libbsc/net_init.c')
| -rw-r--r-- | src/libbsc/net_init.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/src/libbsc/net_init.c b/src/libbsc/net_init.c index 4dfc258a5..9d5431964 100644 --- a/src/libbsc/net_init.c +++ b/src/libbsc/net_init.c @@ -44,10 +44,17 @@ struct gsm_network *bsc_network_init(void *ctx, net->num_bts = 0; net->reject_cause = GSM48_REJECT_ROAMING_NOT_ALLOWED; net->T3101 = GSM_T3101_DEFAULT; + net->T3103 = GSM_T3103_DEFAULT; net->T3105 = GSM_T3105_DEFAULT; + net->T3107 = GSM_T3107_DEFAULT; + net->T3109 = GSM_T3109_DEFAULT; + net->T3111 = GSM_T3111_DEFAULT; net->T3113 = GSM_T3113_DEFAULT; + net->T3115 = GSM_T3115_DEFAULT; + net->T3117 = GSM_T3117_DEFAULT; + net->T3119 = GSM_T3119_DEFAULT; net->T3122 = GSM_T3122_DEFAULT; - /* FIXME: initialize all other timers! */ + net->T3141 = GSM_T3141_DEFAULT; /* default set of handover parameters */ net->handover.win_rxlev_avg = 10; |