diff options
| author | Pau Espin Pedrol <pespin@sysmocom.de> | 2020-07-15 20:53:16 +0200 |
|---|---|---|
| committer | laforge <laforge@osmocom.org> | 2020-07-18 21:45:32 +0000 |
| commit | 388ed5848242f56a207abbc854aa5f2c519ffdb1 (patch) | |
| tree | cba548f05a765304637cd04924c65ff17c5faef7 /src/ipaccess | |
| parent | 6b23d7183235cce41d16adbeacf574e8551498d9 (diff) | |
Move struct gsm_bts: gsm_data.* => bts.*
Place all code related to the object into the related file.
Having all the data model in one file made sense in early stage of
development to make progress quickly, but nowadays it hurts more than
helps, due to constantly growing size and more and more bits being
added to the model, gaining in complexity.
Currently, having lots of different objects mixed up in gsm_data.h is a hole
of despair, where nobody can make any sense were to properly put new stuff
in, ending up with functions related to same object in different files
or with wrong prefixes, declarations of non-existing functions, etc.
because people cannot make up their mind on strict relation to objects
in the data model.
Splitting them in files really helps finding code operating on a
specific object and helping with logically splitting in the future.
Change-Id: I00c15f5285b5c1a0109279b7ab192d5467a04ece
Diffstat (limited to 'src/ipaccess')
| -rw-r--r-- | src/ipaccess/Makefile.am | 4 | ||||
| -rw-r--r-- | src/ipaccess/ipaccess-config.c | 1 |
2 files changed, 4 insertions, 1 deletions
diff --git a/src/ipaccess/Makefile.am b/src/ipaccess/Makefile.am index 145ea3989..273530cf5 100644 --- a/src/ipaccess/Makefile.am +++ b/src/ipaccess/Makefile.am @@ -46,6 +46,7 @@ ipaccess_config_SOURCES = \ # FIXME: resolve the bogus dependencies patched around here: ipaccess_config_LDADD = \ + $(top_builddir)/src/osmo-bsc/bts.o \ $(top_builddir)/src/osmo-bsc/abis_nm.o \ $(top_builddir)/src/osmo-bsc/bts_ipaccess_nanobts.o \ $(top_builddir)/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o \ @@ -57,9 +58,10 @@ ipaccess_config_LDADD = \ ipaccess_proxy_SOURCES = \ ipaccess-proxy.c \ stubs.c \ - $(top_srcdir)/src/osmo-bsc/gsm_data.c \ $(NULL) ipaccess_proxy_LDADD = \ + $(top_builddir)/src/osmo-bsc/bts.o \ + $(top_builddir)/src/osmo-bsc/gsm_data.o \ $(OSMO_LIBS) \ $(NULL) diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index f7d733231..34ad57f1c 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -56,6 +56,7 @@ #include <osmocom/abis/abis.h> #include <osmocom/gsm/protocol/gsm_12_21.h> #include <osmocom/bsc/bss.h> +#include <osmocom/bsc/bts.h> struct gsm_network *bsc_gsmnet; |