diff options
| author | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2023-09-09 00:19:33 +0700 |
|---|---|---|
| committer | fixeria <vyanitskiy@sysmocom.de> | 2023-09-13 10:40:45 +0000 |
| commit | c3446ef49e90c1a9e8aad3b888e37f58ddcd968d (patch) | |
| tree | 376a7c94734a9b557e5bb644184b444d8b44e75b /include | |
| parent | 9e1b54254c505f8ce54e623d06ce2da900b16494 (diff) | |
abis_nm: get rid of MAX_BTS_ATTR
This is a partial revert of commit [1], which defined a limit on the
number of attributes and SW Description IEs as a constant and added
a spec. reference. The problem is that there is no such limit in the
referenced 3GPP TS 52.021. The attributes and SW Description IEs are
using TL16V encoding, so there can be as many as the Length part can
represent. It's actually the limitation of our side, since we
allocate a buffer of fixed size on the stack for parsing.
* Remove the MAX_BTS_ATTR and confusing spec. reference.
* For the SW Description IEs, define SW_DESCR_MAX locally.
* For the attributes, define the buffer size in place.
Change-Id: Idd8b971d32cf0f7a910a664d921e644b7c32d831
Related: [1] 1ebf23b7fe "Prepare for BTS attribute reporting via OML"
Related: OS#4505
Diffstat (limited to 'include')
| -rw-r--r-- | include/osmocom/bsc/abis_nm.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/include/osmocom/bsc/abis_nm.h b/include/osmocom/bsc/abis_nm.h index bfafa63ed..7f1ec7447 100644 --- a/include/osmocom/bsc/abis_nm.h +++ b/include/osmocom/bsc/abis_nm.h @@ -29,9 +29,6 @@ #include <osmocom/bsc/gsm_data.h> #include <osmocom/bsc/signal.h> -/* max number of attributes represented as 3GPP TS 52.021 ยง9.4.62 SW Description array */ -#define MAX_BTS_ATTR 5 - /* The BCCH info from an ip.access test, in host byte order * and already parsed... */ struct ipac_bcch_info { |