Support building with -Werror=strict-prototypes / -Werror=old-style-definition

Unfortunately "-std=c99" is not sufficient to make gcc ignore cold that
uses constructs of earlier C standards, which were abandoned in C99.

See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for
some related discussion.

Change-Id: Ic92aa70d569778a776f4c5d24c455f71fd50b61b

10 files changed, 15 insertions, 14 deletions

diff --git a/include/osmocom/bsc/assignment_fsm.h b/include/osmocom/bsc/assignment_fsm.h
index 98bec420e..3dffaf212 100644
--- a/include/osmocom/bsc/assignment_fsm.h
+++ b/include/osmocom/bsc/assignment_fsm.h
@@ -40,7 +40,7 @@ enum assignment_fsm_event {
 	ASSIGNMENT_EV_CONN_RELEASING,
 };
 
-void assignment_fsm_init();
+void assignment_fsm_init(void);
 
 int reassignment_request_to_lchan(enum assign_for assign_for, struct gsm_lchan *lchan, struct gsm_lchan *to_lchan,
 				  int tsc_set, int tsc);
diff --git a/include/osmocom/bsc/bsc_stats.h b/include/osmocom/bsc/bsc_stats.h
index e8837aa1e..eae97509c 100644
--- a/include/osmocom/bsc/bsc_stats.h
+++ b/include/osmocom/bsc/bsc_stats.h
@@ -113,4 +113,4 @@ extern const struct osmo_stat_item_group_desc bsc_statg_desc;
 void bsc_update_connection_stats(struct gsm_network *net);
 
 void all_allocated_update_bts(struct gsm_bts *bts);
-void all_allocated_update_bsc();
+void all_allocated_update_bsc(void);
diff --git a/include/osmocom/bsc/bsc_subscr_conn_fsm.h b/include/osmocom/bsc/bsc_subscr_conn_fsm.h
index 0ab484372..b358da656 100644
--- a/include/osmocom/bsc/bsc_subscr_conn_fsm.h
+++ b/include/osmocom/bsc/bsc_subscr_conn_fsm.h
@@ -57,7 +57,7 @@ struct osmo_mgcpc_ep_ci;
 struct assignment_request;
 struct gsm_lchan;
 
-void bsc_subscr_conn_fsm_init();
+void bsc_subscr_conn_fsm_init(void);
 
 /* Allocate a subscriber connection and its associated FSM */
 struct gsm_subscriber_connection *bsc_subscr_con_allocate(struct gsm_network *net);
diff --git a/include/osmocom/bsc/chan_counts.h b/include/osmocom/bsc/chan_counts.h
index c11473e71..a830e8745 100644
--- a/include/osmocom/bsc/chan_counts.h
+++ b/include/osmocom/bsc/chan_counts.h
@@ -6,11 +6,11 @@ struct gsm_bts_trx;
 struct gsm_bts_trx_ts;
 struct gsm_lchan;
 
-void chan_counts_sig_init();
+void chan_counts_sig_init(void);
 void chan_counts_ts_update(struct gsm_bts_trx_ts *ts);
 void chan_counts_ts_clear(struct gsm_bts_trx_ts *ts);
 void chan_counts_trx_update(struct gsm_bts_trx *trx);
-void chan_counts_bsc_verify();
+void chan_counts_bsc_verify(void);
 
 /* First array index to chan_counts.val. */
 enum chan_counts_dim1 {
diff --git a/include/osmocom/bsc/handover_fsm.h b/include/osmocom/bsc/handover_fsm.h
index 052e09d79..faec73fcc 100644
--- a/include/osmocom/bsc/handover_fsm.h
+++ b/include/osmocom/bsc/handover_fsm.h
@@ -55,7 +55,7 @@ struct handover_rr_detect_data {
 	const uint8_t *access_delay;
 };
 
-void handover_fsm_init();
+void handover_fsm_init(void);
 
 int handover_request(struct handover_out_req *req);
 void handover_start(struct handover_out_req *req);
diff --git a/include/osmocom/bsc/handover_vty.h b/include/osmocom/bsc/handover_vty.h
index 6ad5276e2..1dd8bf08a 100644
--- a/include/osmocom/bsc/handover_vty.h
+++ b/include/osmocom/bsc/handover_vty.h
@@ -3,6 +3,6 @@
 #include <osmocom/vty/vty.h>
 #include <osmocom/bsc/handover_cfg.h>
 
-void ho_vty_init();
+void ho_vty_init(void);
 void ho_vty_write_net(struct vty *vty, struct gsm_network *net);
 void ho_vty_write_bts(struct vty *vty, struct gsm_bts *bts);
diff --git a/include/osmocom/bsc/lb.h b/include/osmocom/bsc/lb.h
index dbea0b0e1..08206d4d8 100644
--- a/include/osmocom/bsc/lb.h
+++ b/include/osmocom/bsc/lb.h
@@ -57,7 +57,7 @@ struct smlc_config {
 extern const struct rate_ctr_desc smlc_ctr_description[];
 extern const struct rate_ctr_group_desc smlc_ctrg_desc;
 
-int lb_init();
-int lb_start_or_stop();
+int lb_init(void);
+int lb_start_or_stop(void);
 int lb_send(struct gsm_subscriber_connection *conn, const struct bssap_le_pdu *bssap_le);
 void lb_close_conn(struct gsm_subscriber_connection *conn);
diff --git a/include/osmocom/bsc/lchan_fsm.h b/include/osmocom/bsc/lchan_fsm.h
index b9ffb2243..cc231dcf4 100644
--- a/include/osmocom/bsc/lchan_fsm.h
+++ b/include/osmocom/bsc/lchan_fsm.h
@@ -56,7 +56,7 @@ enum lchan_fsm_event {
 	LCHAN_EV_REQUEST_MODE_MODIFY,
 };
 
-void lchan_fsm_init();
+void lchan_fsm_init(void);
 
 void lchan_fsm_alloc(struct gsm_lchan *lchan);
 void lchan_release(struct gsm_lchan *lchan, bool do_rr_release,
diff --git a/include/osmocom/bsc/neighbor_ident.h b/include/osmocom/bsc/neighbor_ident.h
index c6a2c4237..bd14bd409 100644
--- a/include/osmocom/bsc/neighbor_ident.h
+++ b/include/osmocom/bsc/neighbor_ident.h
@@ -73,7 +73,7 @@ void bts_cell_ab(struct cell_ab *arfcn_bsic, const struct gsm_bts *bts);
 int resolve_neighbors(struct gsm_bts **local_neighbor_p, struct gsm0808_cell_id_list2 *remote_neighbors,
 		      struct gsm_bts *from_bts, const struct cell_ab *target_ab, bool log_errors);
 
-void neighbor_ident_vty_init();
+void neighbor_ident_vty_init(void);
 void neighbor_ident_vty_write_bts(struct vty *vty, const char *indent, struct gsm_bts *bts);
 void neighbor_ident_vty_write_network(struct vty *vty, const char *indent);
 
@@ -81,7 +81,7 @@ int neighbor_ident_add_neighbor(struct vty *vty, struct gsm_bts *bts, struct nei
 int neighbor_ident_del_neighbor(struct vty *vty, struct gsm_bts *bts, struct neighbor *n);
 int neighbor_ident_ctrl_init(void);
 
-int neighbors_check_cfg();
+int neighbors_check_cfg(void);
 
 #define CELL_AB_VTY_PARAMS "arfcn <0-1023> bsic (<0-63>|any)"
 #define CELL_AB_VTY_DOC \
diff --git a/include/osmocom/bsc/osmo_bsc.h b/include/osmocom/bsc/osmo_bsc.h
index 13ccdd7b2..ee8cc1312 100644
--- a/include/osmocom/bsc/osmo_bsc.h
+++ b/include/osmocom/bsc/osmo_bsc.h
@@ -17,7 +17,7 @@ struct gsm_audio_support;
 struct gsm_subscriber_connection;
 struct gsm_bts;
 
-struct bsc_api *osmo_bsc_api();
+struct bsc_api *osmo_bsc_api(void);
 
 int bsc_scan_bts_msg(struct gsm_subscriber_connection *conn, struct msgb *msg);
 int bsc_scan_msc_msg(struct gsm_subscriber_connection *conn, struct msgb *msg);
@@ -25,7 +25,8 @@ int bsc_scan_msc_msg(struct gsm_subscriber_connection *conn, struct msgb *msg);
 int bsc_handle_udt(struct bsc_msc_data *msc, struct msgb *msg, unsigned int length);
 int bsc_handle_dt(struct gsm_subscriber_connection *conn, struct msgb *msg, unsigned int len);
 
-int bsc_ctrl_cmds_install();
+struct gsm_network;
+int bsc_ctrl_cmds_install(struct gsm_network *net);
 
 void bsc_gen_location_state_trap(struct gsm_bts *bts);