aboutsummaryrefslogtreecommitdiffstats
path: root/git-version-gen
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2018-03-28 18:14:27 +0200
committerNeels Hofmeyr <neels@hofmeyr.de>2018-03-28 18:59:48 +0200
commitf224509b50e3b9e8ac38c2bf9ff60580f751dfbd (patch)
treecf043609e234e31094b1b62858525b89ea44b076 /git-version-gen
parentcf4a5735e696c333b525425541a76faff2b01bd2 (diff)
fix gsm0408_test: properly free bts struct after each test
Add missing deletion of osmo_stat_item_group_free(bts->bts_statg). Add missing bts free after test_si_ba_ind(). Log deallocation, update expected test output. This fixes some of the errors of gsm0408_test's SI tests, as revealed by a sanitizer build using gcc (Debian 7.3.0-12) 7.3.0. Fixes: ================================================================= ==19273==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d0000004b8 at pc 0x7f1561a94621 bp 0x7ffe7a7a64a0 sp 0x7ffe7a7a6498 WRITE of size 8 at 0x60d0000004b8 thread T0 #0 0x7f1561a94620 in __llist_add ../../../src/libosmocore/include/osmocom/core/linuxlist.h:75 #1 0x7f1561a94620 in llist_add ../../../src/libosmocore/include/osmocom/core/linuxlist.h:90 #2 0x7f1561a94620 in osmo_stat_item_group_alloc ../../../src/libosmocore/src/stat_item.c:141 #3 0x5574f6a19935 in gsm_bts_alloc ../../../../src/osmo-bsc/src/libbsc/gsm_data.c:728 #4 0x5574f6a12920 in bts_init ../../../../src/osmo-bsc/tests/gsm0408/gsm0408_test.c:123 #5 0x5574f6a0ddb3 in test_si2q_e ../../../../src/osmo-bsc/tests/gsm0408/gsm0408_test.c:192 #6 0x5574f6a0ddb3 in main ../../../../src/osmo-bsc/tests/gsm0408/gsm0408_test.c:824 #7 0x7f156061aa86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21a86) #8 0x5574f6a10339 in _start (/n/s/dev/make/osmo-bsc/tests/gsm0408/gsm0408_test+0xfc339) Change-Id: I1ebbd8cc0622ce1a061e933813829b1f770072dc
Diffstat (limited to 'git-version-gen')
0 files changed, 0 insertions, 0 deletions