vty: clarify EGPRS Packet Channel Request message support

According to 3GPP TS 44.060, section 12.24, GPRS Cell Options IE
contains two parameters related to 11 bit Access Burst support:

  - ACCESS_BURST_TYPE - whether the 8 or 11 bit format shall be
    used in the PACKET CHANNEL REQUEST message, the PTCCH/U block,
    PACKET CONTROL ACKNOWLEDGMENT and the PS HANDOVER ACCESS
    messages on the PRACH (if present).

  - EGPRS_PACKET_CHANNEL_REQUEST - whether EGPRS capable MSs shall
    use EGPRS PACKET CHANNEL REQUEST message for Uplink TBF
    establishment on the RACH or on the PRACH (if present).

The VTY option 'gprs 11bit_rach_support_for_egprs' actually controls
the second parameter - EGPRS_PACKET_CHANNEL_REQUEST, though it may
be hard to understand this from its name and description.

This patch is actually a group of tightly related changes:

  - deprecate 'gprs 11bit_rach_support_for_egprs (0|1)':
    - update its description to avoid any possible confusion,
    - print a warning if it's used in non-EGPRS mode,
    - print a warning if it's still used;

  - introduce '[no] gprs egprs-packet-channel-request':
    - ensure that it can only set / printed in the EGPRS mode;

  - take a chance to clean-up / rename the related struct members:
    - 'supports_egprs_11bit_rach' -> bool 'egprs_pkt_chan_request',
    - remove 'supports_egprs_11bit_rach' from 'gprs_cell_options'
      because we already have 'ext_info.use_egprs_p_ch_req' there.

Change-Id: Ied5bd10a806aeeac65ef32339d4ab0e3700e5da9

1 files changed, 9 insertions, 4 deletions

diff --git a/doc/manuals/vty/bsc_vty_reference.xml b/doc/manuals/vty/bsc_vty_reference.xml
index f2266e4e7..dac4ec58b 100644
--- a/doc/manuals/vty/bsc_vty_reference.xml
+++ b/doc/manuals/vty/bsc_vty_reference.xml
@@ -3370,12 +3370,17 @@
         <param name='egprs' doc='EGPRS (EDGE) Enabled on this BTS' />
       </params>
     </command>
-    <command id='gprs 11bit_rach_support_for_egprs (0|1)'>
+    <command id='no gprs egprs-packet-channel-request'>
+      <params>
+        <param name='no' doc='Negate a command or set its defaults' />
+        <param name='gprs' doc='GPRS Packet Network' />
+        <param name='egprs-packet-channel-request' doc='EGPRS Packet Channel Request support' />
+      </params>
+    </command>
+    <command id='gprs egprs-packet-channel-request'>
       <params>
         <param name='gprs' doc='GPRS Packet Network' />
-        <param name='11bit_rach_support_for_egprs' doc='11 bit RACH options' />
-        <param name='0' doc='Disable 11 bit RACH for EGPRS' />
-        <param name='1' doc='Enable 11 bit RACH for EGPRS' />
+        <param name='egprs-packet-channel-request' doc='EGPRS Packet Channel Request support' />
       </params>
     </command>
     <command id='gprs ns timer (tns-block|tns-block-retries|tns-reset|tns-reset-retries|tns-test|tns-alive|tns-alive-retries|tsns-prov) &lt;0-255&gt;'>