aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhilipp Maier <pmaier@sysmocom.de>2022-02-08 11:41:55 +0100
committerPhilipp Maier <pmaier@sysmocom.de>2022-02-08 11:51:42 +0100
commit49865023c9f6a6e4a5fdfaaec27e9d918a2ccaab (patch)
tree6f0050193c4441b7bd57e3b82f47af701ad0e58c
parentf8345b7ad5606d9dc84b1d4d8ad11b0c9758c2b2 (diff)
bssmap_reset: make T4 user configurablepmaier/reset
The timer (T4) that controls the re-sending of the BSSMAP RESET can not be changed via the VTY, althrough it is defined via a tdef struct. Lets add a description along with default values to make it configurable via the VTY. Change-Id: I1fb5699220ab8a643a168567a89c6f381fe433a7 Related: SYS#5796
-rw-r--r--src/osmo-bsc/bssmap_reset.c2
-rw-r--r--src/osmo-bsc/net_init.c1
-rw-r--r--tests/timer.vty2
3 files changed, 4 insertions, 1 deletions
diff --git a/src/osmo-bsc/bssmap_reset.c b/src/osmo-bsc/bssmap_reset.c
index beb89684a..4d24c014b 100644
--- a/src/osmo-bsc/bssmap_reset.c
+++ b/src/osmo-bsc/bssmap_reset.c
@@ -47,7 +47,7 @@ static const struct osmo_tdef_state_timeout bssmap_reset_timeouts[32] = {
osmo_tdef_fsm_inst_state_chg(FI, STATE, \
bssmap_reset_timeouts, \
(bsc_gsmnet)->T_defs, \
- 5)
+ -1)
struct bssmap_reset *bssmap_reset_alloc(void *ctx, const char *label, const struct bssmap_reset_cfg *cfg)
{
diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c
index ec2f881e3..adcffc7a2 100644
--- a/src/osmo-bsc/net_init.c
+++ b/src/osmo-bsc/net_init.c
@@ -27,6 +27,7 @@
#include <osmocom/bsc/neighbor_ident.h>
static struct osmo_tdef gsm_network_T_defs[] = {
+ { .T=4, .default_val=5, .desc="Timeout to receive BSSMAP RESET ACKNOWLEDGE from the MSC" },
{ .T=7, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP HO Required to HO Command timeout" },
{ .T=8, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP HO Command to final Clear timeout" },
{ .T=10, .default_val=6, .desc="RR Assignment" },
diff --git a/tests/timer.vty b/tests/timer.vty
index 12c13adb1..e83207015 100644
--- a/tests/timer.vty
+++ b/tests/timer.vty
@@ -1,6 +1,7 @@
OsmoBSC> enable
OsmoBSC# show timer
+net: T4 = 5 s Timeout to receive BSSMAP RESET ACKNOWLEDGE from the MSC (default: 5 s)
net: T7 = 10 s inter-BSC/MSC Handover outgoing, BSSMAP HO Required to HO Command timeout (default: 10 s)
net: T8 = 10 s inter-BSC/MSC Handover outgoing, BSSMAP HO Command to final Clear timeout (default: 10 s)
net: T10 = 6 s RR Assignment (default: 6 s)
@@ -53,6 +54,7 @@ X4 = 60 s After Clear Request, wait for MSC to Clear Command (sanity) (default:
OsmoBSC# configure terminal
OsmoBSC(config)# network
OsmoBSC(config-net)# timer
+net: T4 = 5 s Timeout to receive BSSMAP RESET ACKNOWLEDGE from the MSC (default: 5 s)
net: T7 = 10 s inter-BSC/MSC Handover outgoing, BSSMAP HO Required to HO Command timeout (default: 10 s)
net: T8 = 10 s inter-BSC/MSC Handover outgoing, BSSMAP HO Command to final Clear timeout (default: 10 s)
net: T10 = 6 s RR Assignment (default: 6 s)