diff options
| author | Pau Espin Pedrol <pespin@sysmocom.de> | 2021-07-05 17:15:12 +0200 |
|---|---|---|
| committer | Pau Espin Pedrol <pespin@sysmocom.de> | 2021-07-05 17:21:42 +0200 |
| commit | 60bcba3bcf69893086d7c6c7389f3c82e342ca5f (patch) | |
| tree | dcbd30afe425bd7b6325f1825719f0e3bb173d5e | |
| parent | 997a257f8dabe5dd940a1271e56e676a871896d7 (diff) | |
assignment_fsm: Fix null pointer dereference rx ASSIGNMENT_EV_LCHAN_ERROR
gsm_lchan_name always expects a valid lchan pointer.
This patch fixes a crash seen:
"""
<000f> lchan_fsm.c:99 lchan(12-2-5-TCH_H-1)[0x559b880f2980]{WAIT_RLL_RTP_ESTABLISH}: (type=TCH_H) Signalling Assignment FSM of error (lchan allocation failed in state WAIT_RLL_RTP_ESTABLISH: Timeout)
Assert failed lchan ../../include/osmocom/bsc/gsm_data.h:1034
"""
Related: SYS#5392
Change-Id: I23a337d411e857954008c6f8ae60be714509d351
| -rw-r--r-- | src/osmo-bsc/assignment_fsm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index f5aee8264..928d3b2bd 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -935,7 +935,7 @@ void assignment_fsm_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, vo assignment_fail(new_lchan->activate.gsm0808_error_cause, "Failed to %s lchan %s", conn->assignment.new_lchan ? "activate" : "modify", - gsm_lchan_name(conn->assignment.new_lchan)); + conn->assignment.new_lchan ? gsm_lchan_name(conn->assignment.new_lchan) : ""); return; default: |