aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhilipp Maier <pmaier@sysmocom.de>2019-07-31 13:15:37 +0200
committerlaforge <laforge@gnumonks.org>2019-08-12 08:43:44 +0000
commit3bc9b16459947b3509256cde912a47a323c20d93 (patch)
treec6c59a1b87edc9533e96f79f468d6e6868bd0bfa
parent3c9485751cd20215ca6029df8dde4be94ee6f39d (diff)
bsc_msc_data: remove unused member is_authenticated
The struct member struct bsc_msc_data->is_authenticated is set to true permanently. This is a leftover from the sccplite implementation and can be removed now. Change-Id: I966a48b383c85345c92c9a1fec791150e96cd7b9 Related: OS#3112
-rw-r--r--include/osmocom/bsc/bsc_msc_data.h1
-rw-r--r--src/osmo-bsc/gsm_08_08.c2
-rw-r--r--src/osmo-bsc/osmo_bsc_msc.c7
3 files changed, 0 insertions, 10 deletions
diff --git a/include/osmocom/bsc/bsc_msc_data.h b/include/osmocom/bsc/bsc_msc_data.h
index 2ad7c685e..56124830c 100644
--- a/include/osmocom/bsc/bsc_msc_data.h
+++ b/include/osmocom/bsc/bsc_msc_data.h
@@ -77,7 +77,6 @@ struct bsc_msc_data {
int core_lac;
int core_ci;
int rtp_base;
- bool is_authenticated;
/* audio codecs */
struct gsm48_multi_rate_conf amr_conf;
diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 6ca5455f6..4dc488348 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -307,8 +307,6 @@ struct bsc_msc_data *bsc_find_msc(struct gsm_subscriber_connection *conn,
round_robin:
llist_for_each_entry(msc, &bsc->mscs, entry) {
- if (!msc->is_authenticated)
- continue;
if (!is_emerg && msc->type != MSC_CON_TYPE_NORMAL)
continue;
if (is_emerg && !msc->allow_emerg)
diff --git a/src/osmo-bsc/osmo_bsc_msc.c b/src/osmo-bsc/osmo_bsc_msc.c
index 7e78d947c..24c8c6d99 100644
--- a/src/osmo-bsc/osmo_bsc_msc.c
+++ b/src/osmo-bsc/osmo_bsc_msc.c
@@ -49,13 +49,6 @@ int osmo_bsc_msc_init(struct bsc_msc_data *msc)
uint16_t mgw_port;
int rc;
- /* FIXME: This is a leftover from the old architecture that used
- * sccp-lite with osmocom specific authentication. Since we now
- * changed to AoIP the connected status and the authentication
- * status is managed differently. However osmo_bsc_filter.c still
- * needs the flags to be set to one. See also: OS#3112 */
- msc->is_authenticated = 1;
-
if (net->mgw.conf->remote_port >= 0)
mgw_port = net->mgw.conf->remote_port;
else