aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVadim Yanitskiy <vyanitskiy@sysmocom.de>2021-01-14 00:02:37 +0100
committerfixeria <vyanitskiy@sysmocom.de>2021-06-30 11:01:20 +0000
commit419d8a296bec3f2192b784605965b1a4ee84976f (patch)
tree7a12a2d3fa3994785dd94e80d3816b8c957cbaef
parenteab874256e9c916728fd896ac7cdb048f01fed24 (diff)
power_control: omit BS Power Parameters IE if the maximum is 0 dB
If BS Power Parameters IE is present in the channel activation message, the BTS shall employ dynamic BS power control for that logical channel and interpret BS Power IE as the maximum value. If the maximum value is 0 dB, then it does not make sense to send BS Power Parameters IE to the BTS, because the power control loop would never exceed the maximum. Change-Id: If8507992dfd90ade1edda99b72bf2420a702ccd5 Related: SYS#4918, SYS#4919
-rw-r--r--src/osmo-bsc/abis_rsl.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 0d921413a..809cd9bc0 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -237,6 +237,12 @@ static void add_power_control_params(struct msgb *msg, enum abis_rsl_ie iei,
if (cp->mode != GSM_PWR_CTRL_MODE_DYN_BTS)
return;
+ /* No dynamic BS power control if the maximum is 0 dB */
+ if (cp->dir == GSM_PWR_CTRL_DIR_DL) {
+ if (lchan->bs_power_db == 0)
+ return;
+ }
+
/* Put tag first, length will be updated later */
uint8_t *ie_len = msgb_tl_put(msg, iei);
uint8_t msg_len = msgb_length(msg);