aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOliver Smith <osmith@sysmocom.de>2020-03-11 11:03:40 +0100
committerOliver Smith <osmith@sysmocom.de>2020-03-12 12:00:24 +0100
commitbeb4af6ff80cbd3537878c05e39cbf957f485e9b (patch)
tree0fbfec1c2323cf1ea5ac6cc1757463991aa71359
parent5291b6429ed3dc258bb146751108599c2216e279 (diff)
osmo-bsc/bsc_vty: set default gprs cell bvci to 2
Do not use 0 as default, as it is reserved for signalling. Related: OS#4408 Change-Id: I499272f16aadd89f3bdb5d749e3e4f9e07056c15
-rw-r--r--src/osmo-bsc/gsm_data.c3
-rw-r--r--tests/gprs_bvci_default.vty13
2 files changed, 16 insertions, 0 deletions
diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 90172dd7c..f12b0324d 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -807,6 +807,9 @@ struct gsm_bts *gsm_bts_alloc(struct gsm_network *net, uint8_t bts_num)
memcpy(&bts->gprs.cell.rlc_cfg, &rlc_cfg_default,
sizeof(bts->gprs.cell.rlc_cfg));
+ /* 3GPP TS 08.18, chapter 5.4.1: 0 is reserved for signalling */
+ bts->gprs.cell.bvci = 2;
+
/* init statistics */
bts->bts_ctrs = rate_ctr_group_alloc(bts, &bts_ctrg_desc, bts->nr);
if (!bts->bts_ctrs) {
diff --git a/tests/gprs_bvci_default.vty b/tests/gprs_bvci_default.vty
new file mode 100644
index 000000000..4bd95ce39
--- /dev/null
+++ b/tests/gprs_bvci_default.vty
@@ -0,0 +1,13 @@
+OsmoBSC> enable
+OsmoBSC# configure terminal
+OsmoBSC(config)# network
+OsmoBSC(config-net)# bts 0
+OsmoBSC(config-net-bts)# gprs mode gprs
+OsmoBSC(config-net-bts)# exit
+
+OsmoBSC(config-net)# show running-config
+...
+ bts 0
+...
+ gprs cell bvci 2
+...