aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2020-09-28 16:51:36 +0200
committerpespin <pespin@sysmocom.de>2020-10-05 08:47:20 +0000
commit37474b2b382995a041f2f70366db9767166db4a6 (patch)
tree994548e1f2014b3ebb7014bac8852d36e0b37e03
parent5fa725314db856b347de8c944e1101026099d43b (diff)
ipa oml: tx OPSTART after unlocking, not before
According to TS 12.21, when adminsitratively Locking an object, in general it should go into operative state Disabled. We don't really implement it this way right now, but keep it this way consistent in all objects. Furthermore, TS 12.21. Figure 2 describes vaguely that unlock procedure is done around same time where object attributes are set, which is before OPSTART. Change-Id: Icd4b3bb467f23c9ddfa56f6b6f8a55da1e574ab8
-rw-r--r--src/osmo-bsc/bts_ipaccess_nanobts.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c
index 796d20812..e02eabc76 100644
--- a/src/osmo-bsc/bts_ipaccess_nanobts.c
+++ b/src/osmo-bsc/bts_ipaccess_nanobts.c
@@ -211,12 +211,12 @@ static int nm_statechg_event(int evt, struct nm_statechg_signal_data *nsd)
0, 0xff, msgb->data,
msgb->len);
msgb_free(msgb);
- abis_nm_opstart(bts, obj_class, bts->bts_nr,
- 0, 0xff);
abis_nm_chg_adm_state(bts, obj_class, bts->bts_nr,
0, 0xff, NM_STATE_UNLOCKED);
abis_nm_chg_adm_state(bts, NM_OC_GPRS_NSE, bts->bts_nr,
0xff, 0xff, NM_STATE_UNLOCKED);
+ abis_nm_opstart(bts, obj_class, bts->bts_nr,
+ 0, 0xff);
}
break;
case NM_OC_GPRS_NSVC:
@@ -234,11 +234,11 @@ static int nm_statechg_event(int evt, struct nm_statechg_signal_data *nsd)
nsvc->id, 0xff,
msgb->data, msgb->len);
msgb_free(msgb);
- abis_nm_opstart(bts, obj_class, bts->bts_nr,
- nsvc->id, 0xff);
abis_nm_chg_adm_state(bts, obj_class, bts->bts_nr,
nsvc->id, 0xff,
NM_STATE_UNLOCKED);
+ abis_nm_opstart(bts, obj_class, bts->bts_nr,
+ nsvc->id, 0xff);
}
default:
break;