diff options
| author | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2020-06-29 11:56:02 +0700 |
|---|---|---|
| committer | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2020-06-29 12:04:12 +0700 |
| commit | a702b61b7da4795e0b3c2a88dd15190b3bcc7a37 (patch) | |
| tree | e23091e56973335faa3c5f7a45c0048cb52ef009 | |
| parent | 68b775b2d3c2941fb7b904382dc42860ce64eeca (diff) | |
abis_rsl: Mobile Allocation IE in CHANnel ACTIVation shall be empty
According to 3GPP TS 48.058 (version 15.0.0), section 9.3.5, the
3GPP TS 24.008 "Mobile Allocation" shall for compatibility reasons
be included but empty, i.e. the length shall be zero. Therefore,
no matter if frequency hopping is in use or not, send it empty.
Change-Id: Ie224a45f10522332eac653fa371564f022108c3f
Related: OS#4545, OS#4546
| -rw-r--r-- | src/osmo-bsc/abis_rsl.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 8376f9816..f6e564b28 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -516,11 +516,10 @@ int rsl_tx_chan_activ(struct gsm_lchan *lchan, uint8_t act_type, uint8_t ho_ref) len = msgb_put(msg, 1); msgb_tv_fixed_put(msg, GSM48_IE_CHANDESC_2, sizeof(cd), (const uint8_t *) &cd); - if (lchan->ts->hopping.enabled) - msgb_tlv_put(msg, GSM48_IE_MA_AFTER, lchan->ts->hopping.ma_len, - lchan->ts->hopping.ma_data); - else - msgb_tlv_put(msg, GSM48_IE_MA_AFTER, 0, NULL); + /* See 3GPP TS 48.058 (version 15.0.0), section 9.3.5 "Channel Identification". + * The 3GPP TS 24.008 "Mobile Allocation" shall for compatibility reasons + * be included but empty, i.e. the length shall be zero. */ + msgb_tlv_put(msg, GSM48_IE_MA_AFTER, 0, NULL); /* update the calculated size */ msg->l3h = len + 1; |