diff options
authorNeels Hofmeyr <neels@hofmeyr.de>2018-11-27 18:19:33 +0100
committerNeels Hofmeyr <neels@hofmeyr.de>2018-11-27 18:19:33 +0100
commite92ce3f0c6a03084c9f1037204c94c9a44c37bdd (patch)
parent686deafa487802c6a99ef099d17d2e963dc2876c (diff)
NOT FOR MERGE: try to find out why there is a conn without an lchanneels/hack
in ttcn3 tests, we currently face a crash where the vty 'handover any' command assumes all conns have an lchan. Don't access a NULL lchan. But first we want to find out why there is a NULL lchan, so log a visible error. Change-Id: If5909b3890cf3f6327b271e53e458a417cebf73f
1 files changed, 5 insertions, 0 deletions
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 983dcb9b3..947ba67df 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -1665,6 +1665,11 @@ static int ho_or_as(struct vty *vty, const char *argv[], int argc)
/* Find the connection/lchan that we want to handover */
llist_for_each_entry(conn, &net->subscr_conns, entry) {
+ if (!conn->lchan) {
+ LOGP(DHO, LOGL_ERROR, "XXXXX found a conn without an lchan: %s %s\n",
+ osmo_fsm_inst_name(conn->fi), bsc_subscr_name(conn->bsub));
+ continue;
+ }
if (conn_get_bts(conn)->nr == bts_nr &&
conn->lchan->ts->trx->nr == trx_nr &&
conn->lchan->ts->nr == ts_nr && conn->lchan->nr == ss_nr) {