diff options
| author | Oliver Smith <osmith@sysmocom.de> | 2023-02-15 10:02:16 +0100 |
|---|---|---|
| committer | osmith <osmith@sysmocom.de> | 2023-02-16 10:37:17 +0000 |
| commit | 23e3e29b7aedfa1cefe91ff0a4d46b1d472ea759 (patch) | |
| tree | c0017b8c10657e5795ecf8119695e8e3cff7c829 | |
| parent | 329e1cdc224995f3561fbc879933f7d8bd53e175 (diff) | |
ho: remove timeout for HO_ST_WAIT_LCHAN_ACTIVE
Remove placeholder timer T23042.
Neels wrote:
> I think the right thing here is to remove this timeout; this needs
> no timeout at all because we can rely on the lchan_fsm to either
> return HO_EV_LCHAN_ACTIVE or HO_EV_LCHAN_ERROR after the usual
> timeouts set for lchan activation. IOW since it is internal to
> osmo-bsc one of the two events is guaranteed to occur.
>
> If we superimpose a timer on top of the lchan timeouts, configuring
> larger lchan activation timeouts becomes complex, because the user
> has to take care to also allow a larger timeout for the same
> procedure during HO.
Related: OS#5787
Change-Id: Ibf740aaa9bddc2de85cf8087ad90bab47aac12c2
| -rw-r--r-- | src/osmo-bsc/handover_fsm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 0d888e024..3742e46fd 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -193,7 +193,7 @@ struct gsm_subscriber_connection *ho_fi_conn(struct osmo_fsm_inst *fi) } static const struct osmo_tdef_state_timeout ho_fsm_timeouts[32] = { - [HO_ST_WAIT_LCHAN_ACTIVE] = { .T = 23042 }, + [HO_ST_WAIT_LCHAN_ACTIVE] = { /* Guarded by X5 + X6 in lchan_fsm_timeouts */ }, [HO_ST_WAIT_MGW_ENDPOINT_TO_MSC] = { .T = 23042 }, [HO_ST_WAIT_RR_HO_DETECT] = { .T = 23042 }, [HO_ST_WAIT_RR_HO_COMPLETE] = { .T = 23042 }, |