diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2020-08-13 12:22:45 +0000 |
|---|---|---|
| committer | Neels Hofmeyr <neels@hofmeyr.de> | 2020-08-13 12:31:51 +0000 |
| commit | e8ec9e5e79847e87e518345d73adbf0cb07a8323 (patch) | |
| tree | fea92594947c0473a9e1877a3049f5b591500cc6 | |
| parent | 6a67fa589ce6aed4e79de0530cb36bda050ec4d6 (diff) | |
gscon timeout: use proper cause code for lchan release
Since we verify the cause code of the RSL channel release in ttcn3-bsc-tests,
BSC_Tests.TC_chan_act_ack_est_ind_noreply shows an invalid release cause code
of 127. Fix that.
On gscon timeout, don't send the unrelated RSL code RSL_ERR_INTERWORKING, but a
proper RR cause code. GSM48_RR_CAUSE_ABNORMAL_TIMER is defined as the proper
cause for an expired timer (3GPP TS 44.018 10.5.2.31).
Should fix this error in BSC_Tests.TC_chan_act_ack_est_ind_noreply:
BSC_Tests.ttcn:1590 Dynamic test case error: Assigning invalid numeric value 127 to a variable of enumerated type @GSM_RR_Types.RR_Cause.
Change-Id: Ic2e4b692e78f7b134fe57d1077a08adb48398e06
| -rw-r--r-- | src/osmo-bsc/bsc_subscr_conn_fsm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index e3976eb20..6a35c755d 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -866,7 +866,7 @@ static int gscon_timer_cb(struct osmo_fsm_inst *fi) switch (fi->T) { case 993210: - gscon_release_lchan(conn, conn->lchan, true, true, RSL_ERR_INTERWORKING); + gscon_release_lchan(conn, conn->lchan, true, true, GSM48_RR_CAUSE_ABNORMAL_TIMER); /* MSC has not responded/confirmed connection with CC, this * could indicate a bad SCCP connection. We now inform the the |