aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVadim Yanitskiy <vyanitskiy@sysmocom.de>2020-08-09 18:55:45 +0700
committerlaforge <laforge@osmocom.org>2020-08-11 06:33:28 +0000
commit6728085988836f49a21b07cea26b33e39235e611 (patch)
tree050c19489759908065ac0503079205d04c81aa05
parentf1d4f366d61bbec9ed6a3eee89f8020585f427c6 (diff)
vty: allow enabling freq. hopping regardless of the feature vector
The hard-coded per-BTS feature vector for osmo-bts currently lacks BTS_FEAT_HOPPING, and this is unlikely to change, because only the recent osmo-bts-trx does support freq. hopping, while the other (DSP based) back-ends do not seem to be capable of doing it. Let's allow enabling freq. hopping regardless of the feature vector, so either it would work if it's supported, or the BTS would reject Set Channel Attributes message by sending NACK on the A-bis/OML. Change-Id: Iff23109cacb5d314f7bcbf34b25e89af9281ce40 Related: SYS#4868, OS#4546
-rw-r--r--src/osmo-bsc/bsc_vty.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 16935d356..9bb650fa8 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -4588,9 +4588,10 @@ DEFUN(cfg_ts_hopping,
int enabled = atoi(argv[0]);
if (enabled && !osmo_bts_has_feature(&ts->trx->bts->model->features, BTS_FEAT_HOPPING)) {
- vty_out(vty, "%% BTS model does not support hopping%s",
- VTY_NEWLINE);
- return CMD_WARNING;
+ vty_out(vty, "%% BTS model does not seem to support freq. hopping%s", VTY_NEWLINE);
+ /* Allow enabling frequency hopping anyway, because the BTS might not have
+ * connected yet (thus not sent the feature vector), so we cannot know for
+ * sure. Jet print a warning and let it go. */
}
ts->hopping.enabled = enabled;