aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2022-06-02 11:44:50 +0200
committerPau Espin Pedrol <pespin@sysmocom.de>2022-06-02 11:44:52 +0200
commitb4269f15ebfe9bb28df0c439e1d7df0f45118a8d (patch)
tree4d7d565d9beb43b72346f1e64cbfb289ff1788b0
parentaae8c2513dfb69eedb2fe3e9ec53bf5b0c261828 (diff)
nm_*_fsm: Remove comment no longer applying
Since b7ef6884f91db7ffe7add51766abc311c9e7d05e, the state is updated before triggering the signal S_NM_STATECHG, so the warning does no longer hold true. Change-Id: I7b7dd30b4fcdc92febca42e3e6a75e6f98e184ff
-rw-r--r--src/osmo-bsc/nm_bb_transc_fsm.c2
-rw-r--r--src/osmo-bsc/nm_bts_fsm.c2
-rw-r--r--src/osmo-bsc/nm_channel_fsm.c2
-rw-r--r--src/osmo-bsc/nm_gprs_cell_fsm.c2
-rw-r--r--src/osmo-bsc/nm_gprs_nse_fsm.c2
-rw-r--r--src/osmo-bsc/nm_gprs_nsvc_fsm.c2
-rw-r--r--src/osmo-bsc/nm_rcarrier_fsm.c2
7 files changed, 0 insertions, 14 deletions
diff --git a/src/osmo-bsc/nm_bb_transc_fsm.c b/src/osmo-bsc/nm_bb_transc_fsm.c
index 957237741..bf2469145 100644
--- a/src/osmo-bsc/nm_bb_transc_fsm.c
+++ b/src/osmo-bsc/nm_bb_transc_fsm.c
@@ -191,8 +191,6 @@ static void st_op_disabled_offline_on_enter(struct osmo_fsm_inst *fi, uint32_t p
{
struct gsm_bts_bb_trx *bb_transc = (struct gsm_bts_bb_trx *)fi->priv;
- /* Warning: In here we may be acessing an state older than new_state
- from prev (syncrhonous) FSM state */
configure_loop(bb_transc, &bb_transc->mo.nm_state, true);
}
diff --git a/src/osmo-bsc/nm_bts_fsm.c b/src/osmo-bsc/nm_bts_fsm.c
index 79ae6a7de..1b71323be 100644
--- a/src/osmo-bsc/nm_bts_fsm.c
+++ b/src/osmo-bsc/nm_bts_fsm.c
@@ -207,8 +207,6 @@ static void st_op_disabled_offline_on_enter(struct osmo_fsm_inst *fi, uint32_t p
{
struct gsm_bts *bts = (struct gsm_bts *)fi->priv;
- /* Warning: In here we may be acessing an state older than new_state
- from prev (syncrhonous) FSM state */
configure_loop(bts, &bts->mo.nm_state, true);
}
diff --git a/src/osmo-bsc/nm_channel_fsm.c b/src/osmo-bsc/nm_channel_fsm.c
index 680e658c8..c3146a41a 100644
--- a/src/osmo-bsc/nm_channel_fsm.c
+++ b/src/osmo-bsc/nm_channel_fsm.c
@@ -168,8 +168,6 @@ static void st_op_disabled_offline_on_enter(struct osmo_fsm_inst *fi, uint32_t p
{
struct gsm_bts_trx_ts *ts = (struct gsm_bts_trx_ts *)fi->priv;
- /* Warning: In here we may be acessing an state older than new_state
- from prev (syncrhonous) FSM state */
configure_loop(ts, &ts->mo.nm_state, true);
}
diff --git a/src/osmo-bsc/nm_gprs_cell_fsm.c b/src/osmo-bsc/nm_gprs_cell_fsm.c
index 9a656e1ef..aabfc0bc5 100644
--- a/src/osmo-bsc/nm_gprs_cell_fsm.c
+++ b/src/osmo-bsc/nm_gprs_cell_fsm.c
@@ -178,8 +178,6 @@ static void st_op_disabled_offline_on_enter(struct osmo_fsm_inst *fi, uint32_t p
{
struct gsm_gprs_cell *cell = (struct gsm_gprs_cell *)fi->priv;
- /* Warning: In here we may be acessing an state older than new_state
- from prev (syncrhonous) FSM state */
configure_loop(cell, &cell->mo.nm_state, true);
}
diff --git a/src/osmo-bsc/nm_gprs_nse_fsm.c b/src/osmo-bsc/nm_gprs_nse_fsm.c
index 4ad623e48..49908cefc 100644
--- a/src/osmo-bsc/nm_gprs_nse_fsm.c
+++ b/src/osmo-bsc/nm_gprs_nse_fsm.c
@@ -179,8 +179,6 @@ static void st_op_disabled_offline_on_enter(struct osmo_fsm_inst *fi, uint32_t p
{
struct gsm_gprs_nse *nse = (struct gsm_gprs_nse *)fi->priv;
- /* Warning: In here we may be acessing an state older than new_state
- from prev (syncrhonous) FSM state */
configure_loop(nse, &nse->mo.nm_state, true);
}
diff --git a/src/osmo-bsc/nm_gprs_nsvc_fsm.c b/src/osmo-bsc/nm_gprs_nsvc_fsm.c
index 75cf4d639..29eed5ca3 100644
--- a/src/osmo-bsc/nm_gprs_nsvc_fsm.c
+++ b/src/osmo-bsc/nm_gprs_nsvc_fsm.c
@@ -194,8 +194,6 @@ static void st_op_disabled_offline_on_enter(struct osmo_fsm_inst *fi, uint32_t p
{
struct gsm_gprs_nsvc *nsvc = (struct gsm_gprs_nsvc *)fi->priv;
- /* Warning: In here we may be acessing an state older than new_state
- from prev (syncrhonous) FSM state */
configure_loop(nsvc, &nsvc->mo.nm_state, true);
}
diff --git a/src/osmo-bsc/nm_rcarrier_fsm.c b/src/osmo-bsc/nm_rcarrier_fsm.c
index 657abea92..fbd31799a 100644
--- a/src/osmo-bsc/nm_rcarrier_fsm.c
+++ b/src/osmo-bsc/nm_rcarrier_fsm.c
@@ -184,8 +184,6 @@ static void st_op_disabled_offline_on_enter(struct osmo_fsm_inst *fi, uint32_t p
{
struct gsm_bts_trx *trx = (struct gsm_bts_trx *)fi->priv;
- /* Warning: In here we may be acessing an state older than new_state
- from prev (syncrhonous) FSM state */
configure_loop(trx, &trx->mo.nm_state, true);
}