diff options
| author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2022-03-03 23:55:36 +0100 |
|---|---|---|
| committer | laforge <laforge@osmocom.org> | 2022-03-09 07:15:51 +0000 |
| commit | c60fabb62b2b8a1b86119041191ad5fb55b2cf8a (patch) | |
| tree | 6cc6c3265c9c1f374a95dfa0563d24527cfd2cca | |
| parent | 826ec9ff758c8a40fca2eaf6cca7989ff6471c83 (diff) | |
fix extraneous newlines in ho_fail() invocations
The ho_fail() macro includes a newline, so the callers should not add
one. Fix these cases where the extra '\n' fragments the logged message.
Related: SYS#5839
Change-Id: Ifdbce98be70c1aa127ae008d7a77b9795fd250d3
| -rw-r--r-- | src/osmo-bsc/handover_fsm.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 75a3497c8..e957a968c 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -664,7 +664,7 @@ void handover_start_inter_bsc_in(struct gsm_subscriber_connection *conn, ho_fsm_update_id(fi, "interBSCin"); if (!parse_ho_request(conn, ho_request_msg, req)) { - ho_fail(HO_RESULT_ERROR, "Invalid Handover Request message from MSC\n"); + ho_fail(HO_RESULT_ERROR, "Invalid Handover Request message from MSC"); return; } @@ -740,7 +740,7 @@ void handover_start_inter_bsc_in(struct gsm_subscriber_connection *conn, chosen_a5_n = select_best_cipher(req->ei_as_bitmask, bsc_gsmnet->a5_encryption_mask); if (chosen_a5_n < 0) { ho_fail(HO_RESULT_FAIL_RR_HO_FAIL, - "There is no A5 encryption mode that both BSC and MSC permit: MSC 0x%x & BSC 0x%x = 0\n", + "There is no A5 encryption mode that both BSC and MSC permit: MSC 0x%x & BSC 0x%x = 0", req->ei_as_bitmask, bsc_gsmnet->a5_encryption_mask); return; } @@ -759,7 +759,7 @@ void handover_start_inter_bsc_in(struct gsm_subscriber_connection *conn, info.encr.alg_id = ALG_A5_NR_TO_RSL(chosen_a5_n); if (chosen_a5_n > 0) { if (req->ei.key_len > sizeof(info.encr.key)) { - ho_fail(HO_RESULT_ERROR, "Encryption Information IE key length is too large: %u\n", + ho_fail(HO_RESULT_ERROR, "Encryption Information IE key length is too large: %u", req->ei.key_len); return; } |