diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2021-04-27 17:26:34 +0200 |
|---|---|---|
| committer | Neels Hofmeyr <neels@hofmeyr.de> | 2021-04-27 17:34:23 +0200 |
| commit | d8e55223ec6b3c1161716ae0884c8006c90c388d (patch) | |
| tree | 460c5fe569eb7d734f49c21ceff41af9bfb28bf7 | |
| parent | 18abd1a808f60e2825d022a683e8b4fbc266c8c6 (diff) | |
Lb: RESET FSM: never send sccp_user == NULL
A crash was reported in bssmap_le_tx_reset() sending a RESET with
sccp_user == NULL. A previous patch fixes what I infer as the root
cause, but I thought let's also have this additional safeguard.
Related: OS#5134
Change-Id: I13834c4e576e8d33e67cb63e222b41255cd94875
| -rw-r--r-- | src/osmo-bsc/lb.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c index 0ff7c5c82..e23de93ca 100644 --- a/src/osmo-bsc/lb.c +++ b/src/osmo-bsc/lb.c @@ -58,6 +58,11 @@ int bssmap_le_tx_reset() }, }; + if (!bsc_gsmnet->smlc->sccp_user) { + LOGP(DRESET, LOGL_DEBUG, "Not sending RESET to SMLC, Lb link down\n"); + return -1; + } + ss7 = osmo_ss7_instance_find(bsc_gsmnet->smlc->cs7_instance); OSMO_ASSERT(ss7); LOGP(DRESET, LOGL_INFO, "Sending RESET to SMLC: %s\n", osmo_sccp_addr_name(ss7, &bsc_gsmnet->smlc->smlc_addr)); |