diff options
author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2015-10-12 14:29:01 +0200 |
---|---|---|
committer | Holger Hans Peter Freyther <holger@moiji-mobile.com> | 2015-11-02 14:13:31 +0100 |
commit | 0dc47484473349400e0205a3f69df44a644f0ba3 (patch) | |
tree | b52f56cbeb207490dd36530725d17608a0347465 | |
parent | 6c06d25667f7c46e179bfd1121c512234c98649f (diff) |
add todo comments
-rw-r--r-- | gtp/gtp.c | 6 |
1 files changed, 6 insertions, 0 deletions
@@ -2179,6 +2179,9 @@ int gtp_update_pdp_conf(struct gsn_t *gsn, int version, if (gtp_conf(gsn, 0, peer, pack, len, &type, &cbp)) return EOF; + /* TODO This function is called from gtp_decaps1c() (for GTP v1) but + * uses gtp0.h.flow (GTP v0 data element) + */ /* Find the context in question */ if (pdp_getgtp0(&pdp, ntoh16(((union gtp_packet *)pack)->gtp0.h.flow))) { gsn->err_unknownpdp++; @@ -2192,6 +2195,9 @@ int gtp_update_pdp_conf(struct gsn_t *gsn, int version, /* Register that we have received a valid teic from GGSN */ pdp->teic_confirmed = 1; + /* TODO This function is called from gtp_decaps1c() (for GTP v1) but + * explicitly passes version 0 and GTP0_HEADER_SIZE to gtpie_decaps() + */ /* Decode information elements */ if (gtpie_decaps (ie, 0, pack + GTP0_HEADER_SIZE, len - GTP0_HEADER_SIZE)) { |