From 86c1db63387bd0dde439a6625c40e9e653b1cf4d Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Fri, 25 Feb 2011 17:10:25 +0100 Subject: nat: Verify that we are not assigning 0x1f as endpoint. On a classic BSC we have 32 channels but one is reserved for signalling. Make sure that we are not assigning 0x1f as we assume that this is the signalling channel. This means that from 32 possible voice channels we are only going to use 30 as we are already not using the 0x0. --- openbsc/tests/bsc-nat/bsc_nat_test.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'openbsc/tests/bsc-nat') diff --git a/openbsc/tests/bsc-nat/bsc_nat_test.c b/openbsc/tests/bsc-nat/bsc_nat_test.c index d5b1ab193..83d75ed68 100644 --- a/openbsc/tests/bsc-nat/bsc_nat_test.c +++ b/openbsc/tests/bsc-nat/bsc_nat_test.c @@ -450,7 +450,7 @@ static void test_mgcp_ass_tracking(void) bsc = bsc_connection_alloc(nat); bsc->cfg = bsc_config_alloc(nat, "foo"); bsc_config_add_lac(bsc->cfg, 2323); - bsc->last_endpoint = 0x1a; + bsc->last_endpoint = 0x1e; con.bsc = bsc; msg = msgb_alloc(4096, "foo"); @@ -475,17 +475,17 @@ static void test_mgcp_ass_tracking(void) abort(); } - if (con.bsc_endp != 0x1b) { + if (con.bsc_endp != 0x1) { fprintf(stderr, "Assigned timeslot should have been 1.\n"); abort(); } - if (con.bsc->_endpoint_status[0x1b] != 1) { + if (con.bsc->_endpoint_status[0x1] != 1) { fprintf(stderr, "The status on the BSC is wrong.\n"); abort(); } int multiplex, timeslot; - mgcp_endpoint_to_timeslot(0x1b, &multiplex, ×lot); + mgcp_endpoint_to_timeslot(0x1, &multiplex, ×lot); uint16_t cic = htons(timeslot & 0x1f); if (memcmp(&cic, &msg->l2h[16], sizeof(cic)) != 0) { @@ -498,7 +498,7 @@ static void test_mgcp_ass_tracking(void) bsc_mgcp_dlcx(&con); if (con.bsc_endp != -1 || con.msc_endp != -1 || - con.bsc->_endpoint_status[1] != 0 || con.bsc->last_endpoint != 0x1b) { + con.bsc->_endpoint_status[1] != 0 || con.bsc->last_endpoint != 0x1) { fprintf(stderr, "Clearing should remove the mapping.\n"); abort(); } -- cgit v1.2.3