From eabdf759363dae0162f2ff8477e64ead599a12ff Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Mon, 22 Aug 2011 23:24:28 +0200 Subject: ctrl: Fix leak, check null pointer --- openbsc/src/osmo-bsc/osmo_bsc_ctrl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/openbsc/src/osmo-bsc/osmo_bsc_ctrl.c b/openbsc/src/osmo-bsc/osmo_bsc_ctrl.c index 31c1d022c..b433d50ca 100644 --- a/openbsc/src/osmo-bsc/osmo_bsc_ctrl.c +++ b/openbsc/src/osmo-bsc/osmo_bsc_ctrl.c @@ -56,6 +56,10 @@ static void generate_location_state_trap(struct gsm_bts *bts, struct bsc_msc_con char *oper, *admin, *policy; cmd = ctrl_cmd_create(msc_con, CTRL_TYPE_TRAP); + if (!cmd) { + LOGP(DCTRL, LOGL_ERROR, "Failed to create TRAP command.\n"); + return; + } cmd->id = "0"; cmd->variable = talloc_asprintf(cmd, "net.bts.%i.location-state", bts->nr); @@ -92,6 +96,7 @@ static void generate_location_state_trap(struct gsm_bts *bts, struct bsc_msc_con cmd->reply = talloc_asprintf_append(cmd->reply, ",%s,%s,%s", oper, admin, policy); osmo_bsc_send_trap(cmd, msc_con); + talloc_free(cmd); } static const struct value_string valid_names[] = { -- cgit v1.2.3