Age | Commit message (Collapse) | Author | Files | Lines |
|
There's already a public API to allocate libosmocore's signal ctx, so
let's use it instead of accessing the global variable. This will allow
to eventually Make the global variable in libosmocore static and
private.
Change-Id: I8dab0ef810adba17fdd242e3a127908dd09b2b42
|
|
From journald output:
/usr/bin/osmo-bsc_mgcp: invalid option -- 's'
Change-Id: I995d2f5909640fc007aa39dd6c6b54ff97ee45f7
|
|
is not yet bound.
We create a new ESME in smsc->esme_list on establishment
of a TCP connection, yet we do not know the system id or
anything else, until the ESME identifies and authenticates.
So do not send alert notifications until we know the
bind status (and system_id)
Change-Id: I0e5d55d3fb6ac46d253902df2fe304e1b0fc8bbf
|
|
Change-Id: I33e1c83a0000789f65acc0b7584d1629a50b384c
|
|
There're no external utilities which rely on it anymore so we can
simplify our packaging by removing it.
Change-Id: I9a96c217999416099aa7ce690845f56fc132274c
|
|
The counterparts in OsmoBSC repo are actively maintained and (partially) packaged
for .deb - let's drop old versions to minimize user confusion.
Change-Id: Ia0cedaad4b717c8c5198842e2acd610f8e03f957
|
|
After libosmocore commit
If1e851ac605c8d2fde3da565b0bd674ea6350c2e
b27e6feb699712345373e87a48187dc622e4fa92
the openbsc master build is broken.
Apply the msgb_wrap_with_TL() rename to msgb_push_tl() to unbreak the build.
Also related is commit e8cd09dd6f3378a8137afb581dcd7ed554daa24c in this
repository, which removed the locally defined msgb_wrap_with_TL() definition.
The libosmocore mistake should have become obvious then and there...
Change-Id: I6fece7bbbea84962daff885e54f0bc0108c8d0a5
|
|
Change-Id: If2180828e2acd28d96754c593c317c2868644c4b
|
|
OSMO-MSC backport
Adds (no) alert-notifications as a per-esme vty command,
in order to allow some ESMEs to be excluded from alerts.
The default is still to send alert notifications to all esme,
so no changes are required to the config file to maintain
identical operation after this patch.
Change-Id: I2b52f2778b24eebc82b2e5e2fb3c2250b1f9e5b0
|
|
Backport of https://gerrit.osmocom.org/11792/
When using smpp-first, after the ESME accepts our STATUS REPORT,
we were sending it locally into gsm340_rx_sms_submit() anyway.
In the case of the ESME mirroring the report back to us, this
would result in two copies of the status report in the SMS
database, which were also both then delivered to the MS.
Some MS then display the REPORT to the user as if it were
a normal SMS.
With this patch, we check if it is the sms_report that has had
receiver set in sms_route_mt_sms() and not the original SMS we
are reporting on, which of course already has receiver set.
Change-Id: I2136489bd21c4755463278a4048a446e5bc4a9d2
|
|
EXTRA_DIST files need to be distributed, no matter if the systemd option
is configured or not.
Change-Id: I8dbb17571df5d6cea040498af2fe57f087bdeb24
|
|
There's increasing gap in functionality between ipaccess utils from this
repo and from osmo-bsc due to ongoing development in new repository. To
avoid potential user confusion let's drop them similar to the way SGSN
was removed earlier.
Change-Id: I9c04f9b469e60802461a2a6e421d3ba27e6dafa1
|
|
Set AM_DISTCHECK_CONFIGURE_FLAGS in Makefile.am instead of
DISTCHECK_CONFIGURE_FLAGS. This is the recommended way from the
automake manual, as otherwise the flag can't be changed by the user
anymore.
Related: OS#3718
Change-Id: I88cc2058bc4ff07d092b060d4cc4e28c3203c625
|
|
From RFC 4867:
octet-align: Permissible values are 0 and 1. If 1, octet-aligned
operation SHALL be used. If 0 or if not present,
bandwidth-efficient operation is employed.
Change-Id: Ic4db7f6d18f650f36f3186965096771f748de5fd
|
|
Remove locally defined function which conflicts with the one in
libosmocore.
Change-Id: Ifcc13c4f8998af7680fc17414b2720feee7d386a
|
|
Not really critical since only user of this function doesn't check the
return value.
Fixes commit: 4a2cc9eb0a0f9424c16b26fcb757483a39d67482
Change-Id: I438349bffaa46a10ad8983090a4b17aed7e00d82
|
|
Change-Id: If5de6e981e9af7b667dd3365d758f868f38bf6e0
|
|
* Refactor code to have unified checks on all paths activating Osmux.
* Improve checkings at activation time and add logging.
* Code now enforces endp osmux status to be enabled before processing
the frame through endp->osmux.out. Before, a delayed or bad pkt could
arrive and be processed by an endp with osmux not enabled, using
endp->osmux.out that was not initialized and ended up crashing:
libosmo-netif/src/osmux.c:281:3: runtime error: member access within null pointer of type 'struct msgb'
This could also happen if a BSC started sending or we received (non legacy dummy) osmux
frames before we received the BSC CRCX ACK agreeing on osmux negotiation
and switching to ACTIVATING state.
Related: SYS#4350
Change-Id: I3536169c94e65f999aaa9c9e43cc7dab8551d30f
|
|
State ACTIVATING is set once negotiation between the 2 parts went
successfuly.
Change-Id: I21eb30fa8d48f3d592ff197bd74e673fdac51c1d
|
|
Change-Id: I285f1cb693b243ecd404337f2bb5b74ddd32b123
|
|
Change-Id: If9249fb0ee2e33c7dd2ab817480776acaa784cc2
|
|
Prior to this commit, the check was only done on legacy dummy frames.
Change-Id: Ief4e62fe68a11a60d90292c72d1263fd1f728356
|
|
enabled
Change-Id: I5244cb9304adef3aa612b8126bf95e77562c801c
|
|
Change-Id: I9f686404517bf8a2044cf59dd5bfaf90eb4f798f
|
|
Change-Id: I581f40da47614223219800e97a334f8b5e06b13f
|
|
Change-Id: I281964935312161d1da49e8035c5bf3bb7bf9c5c
|
|
Otherwise we end up in a weird state where we have timers set up but
osmux is still flagged as not enabled.
Change-Id: I15c3a1a6bdf2566b03d1d543d8d15e4117a53622
|
|
According to verify_chan_comb(), nanoBTS supports SDCCH8 only in TS1.
Change-Id: I37b91745ddf7000add3c24f6bb782ae0c61d2978
|
|
Since that define is already used to allocate size of osmux_cid_bitmap,
let's use it here too instead of hardcoding its value.
Change-Id: I768ca1b510bf44508ae064dc31620e739260470b
|
|
A previous commit merged today fixed array size boundary (multiple of 8
bits), but removed a required +1 which should be kept on top, because
OSMUX_CID_MAX specified the maximum number used by a CID, that is
(0,OSMUX_CID_MAX), and as a result we require OSMUX_CID_MAX+1 slots.
Fixes: 65f422ad5878165be0a1eb05605aa3099536f0c8
Change-Id: I182c9c1a6dd28a4c5c0d8107d53852cf47541592
|
|
It shows up all the time in logs while using "logging level all info",
let's move it to debug.
Change-Id: I51274dad5afef16e466921c5d58672427d23fd3b
|
|
Right now it's not a big issue since OSMUX_CID_MAX is 255, so 255+1 is
256 which fits array boundaries correctly (multiple of 8). However, if
for example OSMUC_CID_MAX was modified to be 12, 12+1/8 = 1, so we'd
have an undesired memory access when accessing last 4 CIDs.
Change-Id: I5908ee44404686e68d61f255b7014af39c8f5703
|
|
bsc_msc_lost will close the current fd (without freeing it), so let's
skip possible writes to an already closed fd
bsc_msc_lost will close the current fd (without freeing it), so let's
skip possible writes to an already closed fd..
Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa
|
|
PONG is being sent a as an answer to PING a few lines above in same
function.
Change-Id: I88ca95d46f4ace1da4025d12302422dbfa578354
|
|
Code is already doing stuff with the connection (fd).
Change-Id: Ieeaa0e024b9542d1a22a8e3ab4c3229a6f8a0b49
|
|
Change-Id: Ib36b8937d1210488784ebae6917cb1b4c871c9d4
|
|
Change-Id: I080ae6a4c4f92dd8df055efd25e308f8a3377d34
|
|
Change-Id: I9bc40cf9e9a901d28d1f1629f6f1d55e8ba0c0b6
|
|
osmux_xfrm_input_open_circuit returns 0 on success and -1 on error.
Confusion comes from that function being implemented by calling
osmux_batch_add_circuit which returns NULL on error.
Change-Id: I98700aa1e2fab9784706bfac1a47cc84635172b7
|
|
Change-Id: I88ba349e547c8f85e12e1ad80a2724086c489c02
|
|
Change-Id: I29d719fbe059e38fde97371efc5e562901529b7c
|
|
Back-port from osmo-bsc.git 9862bcb5cdb9ece0acfdfb7c81e00c05fcd33ad3.
ipaccess_drop_oml was being called inside an osmo_fd cb context, were
-EBADF must be returned if the structure holding the osmo_fd is freed.
In the middle of the path (see OS#3495 for path tree) it goes through a
signal dispatch, so it's impossible to make sure we return some value to
the osmo_fd cb. As a result, it is required to defer dropping the OML
Link from current code path and do it through a timer.
Fixes following ASan report:
20180822124927913 <0004> abis_nm.c:787 OC=RADIO-CARRIER(02) INST=(00,00,ff): CHANGE ADMINISTRATIVE STATE NACK CAUSE=Message cannot be performed
20180822124927913 <0004> osmo_bsc_main.c:186 Got CHANGE ADMINISTRATIVE STATE NACK going to drop the OML links.
20180822124927913 <0015> bts_ipaccess_nanobts.c:406 (bts=0) Dropping OML link.
...
=================================================================
==17607==ERROR: AddressSanitizer: heap-use-after-free on address 0x62e000060a68 at pc 0x7f5ea8e27086 bp 0x7ffde92b6d80 sp 0x7ffde92b6d78
READ of size 8 at 0x62e000060a68 thread T0
#0 0x7f5ea8e27085 in handle_ts1_write input/ipaccess.c:371
#1 0x7f5ea8e27085 in ipaccess_fd_cb input/ipaccess.c:391
#2 0x7f5ea9147ca8 in osmo_fd_disp_fds libosmocore/src/select.c:217
#3 0x7f5ea9147ca8 in osmo_select_main libosmocore/src/select.c:257
#4 0x555813ab79d6 in main osmo-bsc/osmo_bsc_main.c:922
#5 0x7f5ea76d02e0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202e0)
#6 0x555813ab84e9 in _start (/bin/osmo-bsc+0x34d4e9)
Fixes: OS#3495
Change-Id: If9e73a3251547625a2372d58f1d8b87210d9f312
|
|
Back-port from osmo-bsc.git 24f2f55132f7230e387aef85612dcd6fc59cebe5.
Change-Id: I134a3da3700381043bc93aed300ce4ec263e8698
|
|
The '.' is illegal character in counter names, as they are exported
via CTRL interface, where '.' has a special meaning that cannot be
used by strings comprising the variable name.
Change-Id: I075c0f992e2e31226bd04b9c036ca125467f840e
|
|
Some distributions (archlinux) or versions of libgsm install gsm.h in
/usr/include/gsm/gsm.h
Since libgsm doesn't come with a pkfconfig, let's first check if gsm.h
and take the correct path in the build setup.
Backport from osmo-mgw.git
Change-Id: I07d3c03903e0d4bb80e843c7ed917a27b791ea53
|
|
Ensure that all msgb were cleaned up, then free the overall msgb_ctx, in order
to not leave any memory leaks the sanitizer build complains about.
Backport from osmo-mgw.git
Change-Id: I84e0ac7f0928f04ffddd7da18200466841589c25
|
|
Backport from osmo-mgw.git.
Change-Id: Ife3f034ddaaba993bf27c1f9a34a1d57d1bf3e05
|
|
Backport from osmo-mgw.git 020e89bce914d394352dddb8186b65a319562b20.
Change-Id: Ibfc80f06b2811cc32fe38518b11efd6764b347ee
|
|
Currently the force_realloc feature is turnd on and of in a
hardcoded way. This patch makes the option available via VTY.
Backport from osmo-mgw.git.
Change-Id: Ic8740512c5ea0766ff6ceb1c28b9c2b3fe46e75f
|
|
Backport partially (related parts) of osmo-mgw.git
a1756f320acb7021c501d56252db133012ad479f ["Implement IuCS (large
refactoring and addition)"]
Change-Id: I375e67874ccfaadd92d203a911444294d40dfc22
|