diff options
author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2016-05-10 13:56:43 +0200 |
---|---|---|
committer | Harald Welte <laforge@gnumonks.org> | 2016-12-02 12:09:17 +0000 |
commit | 1a60644eb21a5c50eddc5790444022fd5aa11df8 (patch) | |
tree | 1fa3addcc94f21f3f043e49cbd616e1726bb0123 /openbsc/tests/channel | |
parent | ea11bf80955bbbbacb4589f6cc015ab470ad98e8 (diff) |
reinvent connection_for_subscr() and move to libmsc
Implement connection_for_subscr() from a completely different angle: instead of
looking up lchans in bts structs, look up the subscriber in the global list of
gsm_subscriber_connection. static lchan_find() is thus obsoleted.
All callers of connection_for_subscr() live in libmsc, so move to libmsc.
The move and edit are done in a single commit since the old and new
implementation have nothing in common.
Future: osmo-cscn will use this, without bts being present.
Remove implementation of connection_for_subscr() from channel_test.c -- it is
possible that the abort() in there was intended for a regression test, but
actually it seems the implementation was merely added for linking reasons, and
the abort() added to guard against the NULL return value: no comment nor the
commit log indicate that the abort() is test critical; the addition was the
only change in channel_test.c for that commit; at the same time a
connection_for_subscr() call was added in libmsc.
Change-Id: I5e0ba0ecf1726ebd540800f4e98fdfc937c904ff
Diffstat (limited to 'openbsc/tests/channel')
-rw-r--r-- | openbsc/tests/channel/channel_test.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/openbsc/tests/channel/channel_test.c b/openbsc/tests/channel/channel_test.c index 351bb5aa3..c69c70139 100644 --- a/openbsc/tests/channel/channel_test.c +++ b/openbsc/tests/channel/channel_test.c @@ -138,8 +138,6 @@ void gsm_net_update_ctype(struct gsm_network *network) {} void gsm48_secure_channel() {} void paging_request_stop() {} void vty_out() {} -void* connection_for_subscr(void) { abort(); return NULL; } - struct tlv_definition nm_att_tlvdef; |