path: root/openbsc/src/libmsc/osmo_msc.c
diff options
authorHolger Hans Peter Freyther <holger@moiji-mobile.com>2013-06-30 15:30:47 +0200
committerHolger Hans Peter Freyther <holger@moiji-mobile.com>2013-07-27 21:39:13 +0200
commite7bd863f763809b152fb21655abe7e8bba557561 (patch)
treedd6b2a11d9aeec000ebbbb44ed178d4a0dfd0970 /openbsc/src/libmsc/osmo_msc.c
parentb97089432f43505329b57630c5520d555ec998d1 (diff)
expiration: Speculative fixes for the periodic expiring handling
We were expiring subscribers during active calls. This is because the T3212 is stopped under certain conditions but we didn't stop that timer at all. Remember if T3212 timer was stopped due something done by NITB and update the expiration time at the end of the radio connection, as the phone should restart it when returning to MM Idle. It is a bit difficult to decide when we should set the flag. E.g. in a CM Service Request we don't know if we accept the service and during a LU we already send MM messages before we accept or reject the subscriber. The easiest is to set the flag when receiving a paging response on known subscribers and at the end of the authentication process. Do not expire a subscriber that has an active connection that is marked with the flag, e.g. we would still expire a subscriber that is being paged. Manual tests executed/passed: * gst LUTest.st verified that a expiration date was set * gst SMSTest.st (doing another LU but forcing a timeout on the SMS sending). Verified that the expire_lu was updated.
Diffstat (limited to 'openbsc/src/libmsc/osmo_msc.c')
1 files changed, 10 insertions, 1 deletions
diff --git a/openbsc/src/libmsc/osmo_msc.c b/openbsc/src/libmsc/osmo_msc.c
index 452de62d5..31b72b925 100644
--- a/openbsc/src/libmsc/osmo_msc.c
+++ b/openbsc/src/libmsc/osmo_msc.c
@@ -1,7 +1,7 @@
/* main MSC management code... */
- * (C) 2010 by Holger Hans Peter Freyther <zecke@selfish.org>
+ * (C) 2010,2013 by Holger Hans Peter Freyther <zecke@selfish.org>
* (C) 2010 by On-Waves
* All Rights Reserved
@@ -158,6 +158,15 @@ void msc_release_connection(struct gsm_subscriber_connection *conn)
/* no more connections, asking to release the channel */
+ /*
+ * We had stopped the LU expire timer T3212. Now we are about
+ * to send the MS back to the idle state and this should lead
+ * to restarting the timer. Set the new expiration time.
+ */
+ if (conn->expire_timer_stopped)
+ subscr_update_expire_lu(conn->subscr, conn->bts);
conn->in_release = 1;
if (conn->put_channel) {