diff options
| author | Pablo Neira Ayuso <pablo@gnumonks.org> | 2017-08-07 14:01:05 +0100 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@gnumonks.org> | 2017-08-08 10:20:20 +0200 |
| commit | 3e4295287f1a2866e6e512517a2c94f608ecbd30 (patch) | |
| tree | 6db06d65a01a5e31e8dbeff5ed7e7d1cf9cec8c3 /openbsc/src/libmsc/gsm_04_11.c | |
| parent | 18ca1ce2ea9f0c353e6886a9d05c61238bba9dc6 (diff) | |
libmsc: remove dead code in sms_route_mt_sms()
The following branch:
if (!rc && !gsms->receiver)
rc = GSM411_RP_CAUSE_MO_NUM_UNASSIGNED;
at the end of sms_route_mt_sms() always evaluates false.
Just a bit before, in such function, we have this:
if (!gsms->receiver) {
...
#ifdef BUILD_SMPP
...
#else
...
#endif
return rc;
}
So, if there is no receiver, we just stop running code and return the RP
cause via the rc variable. Same applies to the smpp_first check under
the BUILD_SMPP ifdef (that I have removed in this snippet to keep this
commit message small).
Change-Id: Ic3502b5b169bc7a73a67fd6ff53d8b6c0dc045c8
Diffstat (limited to 'openbsc/src/libmsc/gsm_04_11.c')
| -rw-r--r-- | openbsc/src/libmsc/gsm_04_11.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/openbsc/src/libmsc/gsm_04_11.c b/openbsc/src/libmsc/gsm_04_11.c index da4460c2f..7df5e649d 100644 --- a/openbsc/src/libmsc/gsm_04_11.c +++ b/openbsc/src/libmsc/gsm_04_11.c @@ -356,9 +356,6 @@ try_local: break; } - if (!rc && !gsms->receiver) - rc = GSM411_RP_CAUSE_MO_NUM_UNASSIGNED; - return rc; } |