diff options
author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2016-03-07 17:19:19 +0100 |
---|---|---|
committer | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2016-03-14 23:58:23 +0100 |
commit | 9e8e0e6a2930afbf3e156e3be945f17c117086ea (patch) | |
tree | c6c1169a2afc5407eb796447fc285fa9053791f8 /openbsc/src/libmsc/auth.c | |
parent | cf3d2a1fad3de8a7d914282f2b1f9eee319910c3 (diff) |
Remove unused auth code and add comment
As commented in the code, the GSM_SECURITY_AUTH_FAILED path is never invoked by
the gsm48_secure_channel() function as it is today.
Note that the upcoming Iu auth will probably add a GSM_SECURITY_AUTH_FAILED
status. In that case, sending a LU Reject immediately may be desirable, but
arguably a bit of timeout could make life harder for auth attackers.
The code removed by this patch doesn't send out a LU Reject ever, since a call
to release_loc_updating_req() only releases the connection. To reject, a call
to gsm0408_loc_upd_rej() would be necessary, as seen in loc_upd_rej_cb().
And finally, if _gsm0408_authorize_sec_cb() doesn't do anything about anything,
the same loc_upd_rej_cb() will be run by a timeout and send a LU Reject
properly (as commented in the code).
Diffstat (limited to 'openbsc/src/libmsc/auth.c')
0 files changed, 0 insertions, 0 deletions