diff options
author | Harald Welte <laforge@gnumonks.org> | 2016-04-27 18:21:16 +0200 |
---|---|---|
committer | Harald Welte <laforge@gnumonks.org> | 2016-04-29 13:10:37 +0200 |
commit | 5d547a4358edbd18744d1996d6ecb40328f09061 (patch) | |
tree | 866489ca9f7ec7be7ee8016e41680d61a819bb29 /openbsc/src/gprs/oap_messages.c | |
parent | d8aa412c46638abea05488ebb2e9d70ca7fd628a (diff) |
osmo_oap_decode(): Use common argument ordering
In general, if a function generates output data like a msgb (or in this
case filling an osmo_oap_message structure), the output argument
precedes the source. This is what we use all over libosmo*, and it is
modelled after memcpy(), where dst is the first argument, before src.
Let's align osmo_oap_decode(). Intestingly, osmo_oap_encode was already
correct, so the encode/decode functions used different conventions
before.
Diffstat (limited to 'openbsc/src/gprs/oap_messages.c')
-rw-r--r-- | openbsc/src/gprs/oap_messages.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/openbsc/src/gprs/oap_messages.c b/openbsc/src/gprs/oap_messages.c index 53ea9ac84..d81723fd6 100644 --- a/openbsc/src/gprs/oap_messages.c +++ b/openbsc/src/gprs/oap_messages.c @@ -31,8 +31,8 @@ #include <stdint.h> -int osmo_oap_decode(const uint8_t *const_data, size_t data_len, - struct osmo_oap_message *oap_msg) +int osmo_oap_decode(struct osmo_oap_message *oap_msg, + const uint8_t *const_data, size_t data_len) { int rc; uint8_t tag; |