aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJacob Erlbeck <jerlbeck@sysmocom.de>2013-10-29 09:30:31 +0100
committerHolger Hans Peter Freyther <holger@moiji-mobile.com>2013-10-30 15:19:02 +0100
commit6e919dbb653d4b0c209d393b2a5cf5bf8de9be62 (patch)
treef5e9623436228292497cf00fcff6a1a8b9e412bf
parent36722e13daa0be478cba2cf020e5fe80a6218ac2 (diff)
vty: Enable the end/exit test for libosmocore nodes
This patch replaces the calls to ignoredCheckForEndAndExit by calls to checkForEndAndExit to test the libosmocore nodes, too. The former method is removed. Sponsored-by: On-Waves ehf
-rw-r--r--openbsc/tests/vty_test_runner.py19
1 files changed, 6 insertions, 13 deletions
diff --git a/openbsc/tests/vty_test_runner.py b/openbsc/tests/vty_test_runner.py
index 18cf68867..45b0c063d 100644
--- a/openbsc/tests/vty_test_runner.py
+++ b/openbsc/tests/vty_test_runner.py
@@ -67,18 +67,11 @@ class TestVTYGenericBSC(TestVTYBase):
self.assert_(res.find(' end\r') > 0)
#print 'found "end"\n'
- def ignoredCheckForEndAndExit(self):
- sys.stderr.write('Going to ignore the next assertion(s) due to known bugs\n')
- try:
- self.checkForEndAndExit()
- except BaseException as e:
- sys.stderr.write('Expected and ignored failure: %s\n' % (str(e)))
-
def _testConfigNetworkTree(self):
self.vty.enable()
self.assertTrue(self.vty.verify("configure terminal",['']))
self.assertEquals(self.vty.node(), 'config')
- self.ignoredCheckForEndAndExit()
+ self.checkForEndAndExit()
self.assertTrue(self.vty.verify("network",['']))
self.assertEquals(self.vty.node(), 'config-net')
self.checkForEndAndExit()
@@ -129,7 +122,7 @@ class TestVTYNITB(TestVTYGenericBSC):
self.vty.enable()
self.assertTrue(self.vty.verify("configure terminal", ['']))
self.assertEquals(self.vty.node(), 'config')
- self.ignoredCheckForEndAndExit()
+ self.checkForEndAndExit()
self.assertTrue(self.vty.verify('mncc-int', ['']))
self.assertEquals(self.vty.node(), 'config-mncc-int')
self.checkForEndAndExit()
@@ -139,7 +132,7 @@ class TestVTYNITB(TestVTYGenericBSC):
self.assertEquals(self.vty.node(), 'config')
self.assertTrue(self.vty.verify('smpp', ['']))
self.assertEquals(self.vty.node(), 'config-smpp')
- self.ignoredCheckForEndAndExit()
+ self.checkForEndAndExit()
self.assertTrue(self.vty.verify("exit", ['']))
self.assertEquals(self.vty.node(), 'config')
@@ -247,7 +240,7 @@ class TestVTYBSC(TestVTYGenericBSC):
self.vty.enable()
self.assertTrue(self.vty.verify("configure terminal", ['']))
self.assertEquals(self.vty.node(), 'config')
- self.ignoredCheckForEndAndExit()
+ self.checkForEndAndExit()
self.assertTrue(self.vty.verify("msc 0", ['']))
self.assertEquals(self.vty.node(), 'config-msc')
self.checkForEndAndExit()
@@ -378,7 +371,7 @@ class TestVTYNAT(TestVTYGenericBSC):
self.vty.enable()
self.assertTrue(self.vty.verify('configure terminal', ['']))
self.assertEquals(self.vty.node(), 'config')
- self.ignoredCheckForEndAndExit()
+ self.checkForEndAndExit()
self.assertTrue(self.vty.verify('mgcp', ['']))
self.assertEquals(self.vty.node(), 'config-mgcp')
self.checkForEndAndExit()
@@ -508,7 +501,7 @@ class TestVTYGbproxy(TestVTYGenericBSC):
self.vty.enable()
self.assertTrue(self.vty.verify('configure terminal', ['']))
self.assertEquals(self.vty.node(), 'config')
- self.ignoredCheckForEndAndExit()
+ self.checkForEndAndExit()
self.assertTrue(self.vty.verify('ns', ['']))
self.assertEquals(self.vty.node(), 'config-ns')
self.checkForEndAndExit()