diff options
| author | Harald Welte <laforge@gnumonks.org> | 2017-07-20 01:19:18 +0200 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2017-07-20 09:39:09 +0200 |
| commit | ab2454e776f1a4bc4977ef48ec2844600f85176b (patch) | |
| tree | 6ae7eb762fbf9fc5576c3f66ef74acbf2325e843 | |
| parent | 9f64c54040857079fa5ca35bf522d3befe7ac362 (diff) | |
bsc_vty: Don't allow timers of zero (0)
It typically doesn't make sense to configure any of the GSM RR timer
to 0 (Seconds). In fact, accidentially configuring any of the timers
to zero might have severe side effects, such as "stuck channels"
described in https://osmocom.org/issues/2380
Change-Id: I517828f2f0c80ec01cb63648db2626f17a67fe57
| -rw-r--r-- | openbsc/src/libbsc/bsc_vty.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c index b8352ce1e..bcd78e33a 100644 --- a/openbsc/src/libbsc/bsc_vty.c +++ b/openbsc/src/libbsc/bsc_vty.c @@ -1544,14 +1544,14 @@ DEFUN(cfg_net_pag_any_tch, #define DECLARE_TIMER(number, doc) \ DEFUN(cfg_net_T##number, \ cfg_net_T##number##_cmd, \ - "timer t" #number " <0-65535>", \ + "timer t" #number " <1-65535>", \ "Configure GSM Timers\n" \ doc "Timer Value in seconds\n") \ { \ struct gsm_network *gsmnet = gsmnet_from_vty(vty); \ int value = atoi(argv[0]); \ \ - if (value < 0 || value > 65535) { \ + if (value < 1 || value > 65535) { \ vty_out(vty, "Timer value %s out of range.%s", \ argv[0], VTY_NEWLINE); \ return CMD_WARNING; \ |