diff options
author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2016-03-22 19:26:34 +0100 |
---|---|---|
committer | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2016-03-22 19:55:45 +0100 |
commit | 4b940126a3132ac6d6da4194229f2b8cb642c2ec (patch) | |
tree | 6b05e9490067b35658ce29b70f05fd46be0c8e99 | |
parent | debb0e386871e64a769d7414b71bedec09d7e76a (diff) |
comments about incomplete MM ciphering
-rw-r--r-- | openbsc/src/libmsc/gsm_04_08.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index 801931f74..9d53eb629 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -1152,8 +1152,13 @@ static int gsm48_rx_mm_auth_resp(struct gsm_subscriber_connection *conn, struct DEBUGPC(DMM, "OK\n"); + /* TODO separate enable flags and/or A5 algos for auth and encryption */ if (net->a5_encryption) /* Start ciphering */ + /* TODO gsm0808_cipher_mode() is still a dummy, and no code + * to receive a Ciphering Mode Complete exists in the MSC. + * As soon as such a receiver exists, it must call + * iu_tx_sec_mode_cmd() as below. */ return gsm0808_cipher_mode(conn, net->a5_encryption, conn->sec_operation->atuple.kc, 8, 0); |