mgcp/test: Add test cases for constant RTP sequence number

This adds two test cases:
  1. Packet repetition (dSeq=0, dTS=0)
  2. Broken seqNo (dSeq=0, dTS=160)

The second had been already present in the test cases, but it was a
mere copy&paste mistake which turned out to be rather helpful. This
patch therefore turns it into a documented test case.

Sponsored-by: On-Waves ehf

2 files changed, 49 insertions, 5 deletions

diff --git a/openbsc/tests/mgcp/mgcp_test.c b/openbsc/tests/mgcp/mgcp_test.c
index 9777a4df9..b93ce7ef2 100644
--- a/openbsc/tests/mgcp/mgcp_test.c
+++ b/openbsc/tests/mgcp/mgcp_test.c
@@ -605,7 +605,27 @@ struct rtp_packet_info test_rtp_packets1[] = {
 	{0.380000, 20, "\x80\x62\x00\x14\x00\x00\x8C\x58\x10\x20\x30\x40"
 		       "\x01\x23\x45\x67\x89\xAB\xCD\xEF"},
 	/* RTP: SeqNo=21, TS=36088 */
-	{0.380000, 20, "\x80\x62\x00\x14\x00\x00\x8C\xF8\x10\x20\x30\x40"
+	{0.380000, 20, "\x80\x62\x00\x15\x00\x00\x8C\xF8\x10\x20\x30\x40"
+		       "\x01\x23\x45\x67\x89\xAB\xCD\xEF"},
+	/* Repeat last packet */
+	/* RTP: SeqNo=21, TS=36088 */
+	{0.400000, 20, "\x80\x62\x00\x15\x00\x00\x8C\xF8\x10\x20\x30\x40"
+		       "\x01\x23\x45\x67\x89\xAB\xCD\xEF"},
+	/* RTP: SeqNo=22, TS=36248 */
+	{0.420000, 20, "\x80\x62\x00\x16\x00\x00\x8D\x98\x10\x20\x30\x40"
+		       "\x01\x23\x45\x67\x89\xAB\xCD\xEF"},
+	/* RTP: SeqNo=23, TS=36408 */
+	{0.440000, 20, "\x80\x62\x00\x17\x00\x00\x8E\x38\x10\x20\x30\x40"
+		       "\x01\x23\x45\x67\x89\xAB\xCD\xEF"},
+	/* Don't increment SeqNo but increment timestamp by 160 */
+	/* RTP: SeqNo=23, TS=36568 */
+	{0.460000, 20, "\x80\x62\x00\x17\x00\x00\x8E\xD8\x10\x20\x30\x40"
+		       "\x01\x23\x45\x67\x89\xAB\xCD\xEF"},
+	/* RTP: SeqNo=24, TS=36728 */
+	{0.480000, 20, "\x80\x62\x00\x18\x00\x00\x8F\x78\x10\x20\x30\x40"
+		       "\x01\x23\x45\x67\x89\xAB\xCD\xEF"},
+	/* RTP: SeqNo=25, TS=36888 */
+	{0.500000, 20, "\x80\x62\x00\x19\x00\x00\x90\x18\x10\x20\x30\x40"
 		       "\x01\x23\x45\x67\x89\xAB\xCD\xEF"},
 };
 
diff --git a/openbsc/tests/mgcp/mgcp_test.ok b/openbsc/tests/mgcp/mgcp_test.ok
index f9dd7cb62..783f3a5fa 100644
--- a/openbsc/tests/mgcp/mgcp_test.ok
+++ b/openbsc/tests/mgcp/mgcp_test.ok
@@ -85,7 +85,13 @@ TS: 2480, dTS: 160, TS Errs: in 7, out 7
 TS: 2640, dTS: 160, TS Errs: in 7, out 7
 TS: 2960, dTS: 160, TS Errs: in 7, out 7
 TS: 3120, dTS: 160, TS Errs: in 7, out 7
-TS: 3280, dTS: 160, TS Errs: in 8, out 8
+TS: 3280, dTS: 160, TS Errs: in 7, out 7
+TS: 3280, dTS: 160, TS Errs: in 7, out 7
+TS: 3440, dTS: 160, TS Errs: in 7, out 7
+TS: 3600, dTS: 160, TS Errs: in 7, out 7
+TS: 3760, dTS: 160, TS Errs: in 8, out 8
+TS: 3920, dTS: 160, TS Errs: in 8, out 8
+TS: 4080, dTS: 160, TS Errs: in 8, out 8
 Testing packet error detection.
 Output SSRC changed to 11223344
 TS: 0, dTS: 0, TS Errs: in 0, out 0
@@ -109,7 +115,13 @@ TS: 35288, dTS: 160, TS Errs: in 7, out 7
 TS: 35448, dTS: 160, TS Errs: in 7, out 7
 TS: 35768, dTS: 160, TS Errs: in 7, out 7
 TS: 35928, dTS: 160, TS Errs: in 7, out 7
-TS: 36088, dTS: 160, TS Errs: in 8, out 8
+TS: 36088, dTS: 160, TS Errs: in 7, out 7
+TS: 36088, dTS: 160, TS Errs: in 7, out 7
+TS: 36248, dTS: 160, TS Errs: in 7, out 7
+TS: 36408, dTS: 160, TS Errs: in 7, out 7
+TS: 36568, dTS: 160, TS Errs: in 8, out 8
+TS: 36728, dTS: 160, TS Errs: in 8, out 8
+TS: 36888, dTS: 160, TS Errs: in 8, out 8
 Testing packet error detection, patch timestamps.
 Output SSRC changed to 11223344
 TS: 0, dTS: 0, TS Errs: in 0, out 0
@@ -133,7 +145,13 @@ TS: 35368, dTS: 160, TS Errs: in 7, out 0
 TS: 35528, dTS: 160, TS Errs: in 7, out 0
 TS: 35848, dTS: 160, TS Errs: in 7, out 0
 TS: 36008, dTS: 160, TS Errs: in 7, out 0
-TS: 36008, dTS: 160, TS Errs: in 8, out 0
+TS: 36168, dTS: 160, TS Errs: in 7, out 0
+TS: 36168, dTS: 160, TS Errs: in 7, out 0
+TS: 36328, dTS: 160, TS Errs: in 7, out 0
+TS: 36488, dTS: 160, TS Errs: in 7, out 0
+TS: 36488, dTS: 160, TS Errs: in 8, out 0
+TS: 36648, dTS: 160, TS Errs: in 8, out 0
+TS: 36808, dTS: 160, TS Errs: in 8, out 0
 Testing packet error detection, patch SSRC, patch timestamps.
 Output SSRC changed to 11223344
 TS: 0, dTS: 0, TS Errs: in 0, out 0
@@ -156,5 +174,11 @@ TS: 2560, dTS: 160, TS Errs: in 7, out 0
 TS: 2720, dTS: 160, TS Errs: in 7, out 0
 TS: 3040, dTS: 160, TS Errs: in 7, out 0
 TS: 3200, dTS: 160, TS Errs: in 7, out 0
-TS: 3200, dTS: 160, TS Errs: in 8, out 0
+TS: 3360, dTS: 160, TS Errs: in 7, out 0
+TS: 3360, dTS: 160, TS Errs: in 7, out 0
+TS: 3520, dTS: 160, TS Errs: in 7, out 0
+TS: 3680, dTS: 160, TS Errs: in 7, out 0
+TS: 3680, dTS: 160, TS Errs: in 8, out 0
+TS: 3840, dTS: 160, TS Errs: in 8, out 0
+TS: 4000, dTS: 160, TS Errs: in 8, out 0
 Done