diff options
| author | Andreas Eversberg <jolly@eversberg.eu> | 2013-03-14 09:41:18 +0100 |
|---|---|---|
| committer | Andreas Eversberg <jolly@eversberg.eu> | 2014-03-13 08:08:39 +0100 |
| commit | e1646a5d595e26b24f1fe2252dabf547bb1b3162 (patch) | |
| tree | 4e49b590173eb493337538cb12897763644289a5 | |
| parent | b01c271f4d478787448e5e271e2b2a72e040127d (diff) | |
Drop bad speech frames rather than forwarding them via RTP
Some RTP endpoints may not check for bad frame indications, so a frame
that is marked as bad may be still forwarded, which creates anoying noise.
This patch drops these frames. It depends on the other RTP endpoint how
dropped frames are handled. (insert silence, extrapolate speech...)
| -rw-r--r-- | openbsc/src/libtrau/rtp_proxy.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/openbsc/src/libtrau/rtp_proxy.c b/openbsc/src/libtrau/rtp_proxy.c index 52abad0ce..0aa325d24 100644 --- a/openbsc/src/libtrau/rtp_proxy.c +++ b/openbsc/src/libtrau/rtp_proxy.c @@ -327,27 +327,36 @@ int rtp_send_frame(struct rtp_socket *rs, struct gsm_data_frame *frame) switch (frame->msg_type) { case GSM_TCHF_FRAME: + if ((frame->data[0] >> 4) != 0xd) + goto bfi; payload_type = RTP_PT_GSM_FULL; payload_len = RTP_LEN_GSM_FULL; duration = RTP_GSM_DURATION; break; case GSM_TCHF_FRAME_EFR: + if ((frame->data[0] >> 4) != 0xc) + goto bfi; payload_type = (dynamic_pt) ? : RTP_PT_GSM_EFR; payload_len = RTP_LEN_GSM_EFR; duration = RTP_GSM_DURATION; break; case GSM_TCHH_FRAME: + if ((frame->data[0] & 0xf0) != 0x00) + goto bfi; payload_type = (dynamic_pt) ? : RTP_PT_GSM_HALF; payload_len = RTP_LEN_GSM_HALF; duration = RTP_GSM_DURATION; break; case GSM_TCH_FRAME_AMR: + if ((frame->data[2] & 0x04) != 0x04) + goto bfi; payload_type = (dynamic_pt) ? : RTP_PT_AMR; payload_len = frame->data[0]; duration = RTP_GSM_DURATION; is_amr = 1; break; case GSM_BAD_FRAME: +bfi: payload_type = 0; payload_len = 0; duration = RTP_GSM_DURATION; |