aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHolger Hans Peter Freyther <holger@moiji-mobile.com>2014-05-15 15:45:55 +0200
committerHolger Hans Peter Freyther <holger@moiji-mobile.com>2014-05-15 15:50:55 +0200
commit6e36255221d588f5de20b124748b589249ea825b (patch)
tree5fbaa4cef1d00d3249806fc8a94fd6e9b0f5d3fa
parent1159005ae02f8c9e42624769ec1b2a8d84c9dee5 (diff)
ctrl: Remove the param parameter as it was never used/implemented
-rw-r--r--openbsc/include/openbsc/control_cmd.h4
-rw-r--r--openbsc/src/libbsc/bsc_ctrl_commands.c1
-rw-r--r--openbsc/src/libctrl/control_cmd.c2
3 files changed, 0 insertions, 7 deletions
diff --git a/openbsc/include/openbsc/control_cmd.h b/openbsc/include/openbsc/control_cmd.h
index a87c469a8..479286983 100644
--- a/openbsc/include/openbsc/control_cmd.h
+++ b/openbsc/include/openbsc/control_cmd.h
@@ -66,7 +66,6 @@ struct ctrl_cmd_struct {
struct ctrl_cmd_element {
const char *name;
- const char *param;
struct ctrl_cmd_struct strcmd;
int (*set)(struct ctrl_cmd *cmd, void *data);
int (*get)(struct ctrl_cmd *cmd, void *data);
@@ -125,7 +124,6 @@ static int verify_##cmdname(struct ctrl_cmd *cmd, const char *value, void *_data
CTRL_HELPER_VERIFY_RANGE(cmdname, min, max) \
static struct ctrl_cmd_element cmd_##cmdname = { \
.name = cmdstr, \
- .param = NULL, \
.get = &get_##cmdname, \
.set = &set_##cmdname, \
.verify = &verify_##cmdname, \
@@ -154,7 +152,6 @@ static int set_##cmdname(struct ctrl_cmd *cmd, void *_data) \
CTRL_HELPER_SET_STRING(cmdname, dtype, element) \
static struct ctrl_cmd_element cmd_##cmdname = { \
.name = cmdstr, \
- .param = NULL, \
.get = &get_##cmdname, \
.set = &set_##cmdname, \
.verify = NULL, \
@@ -166,7 +163,6 @@ static int set_##cmdname(struct ctrl_cmd *cmd, void *data); \
static int verify_##cmdname(struct ctrl_cmd *cmd, const char *value, void *data); \
static struct ctrl_cmd_element cmd_##cmdname = { \
.name = cmdstr, \
- .param = NULL, \
.get = &get_##cmdname, \
.set = &set_##cmdname, \
.verify = &verify_##cmdname, \
diff --git a/openbsc/src/libbsc/bsc_ctrl_commands.c b/openbsc/src/libbsc/bsc_ctrl_commands.c
index 37595932f..4c587dca8 100644
--- a/openbsc/src/libbsc/bsc_ctrl_commands.c
+++ b/openbsc/src/libbsc/bsc_ctrl_commands.c
@@ -30,7 +30,6 @@
CTRL_HELPER_SET_STRING(cmdname, dtype, element) \
static struct ctrl_cmd_element cmd_##cmdname = { \
.name = cmdstr, \
- .param = NULL, \
.get = get_##cmdname, \
.set = set_##cmdname, \
.verify = verify_vty_description_string, \
diff --git a/openbsc/src/libctrl/control_cmd.c b/openbsc/src/libctrl/control_cmd.c
index 3c4efc06d..db88668f8 100644
--- a/openbsc/src/libctrl/control_cmd.c
+++ b/openbsc/src/libctrl/control_cmd.c
@@ -142,8 +142,6 @@ int ctrl_cmd_exec(vector vline, struct ctrl_cmd *command, vector node, void *dat
command->reply = "Value failed verification.";
goto out;
}
- } else if (cmd_el->param) {
- LOGP(DCTRL, LOGL_NOTICE, "Parameter verification unimplemented, continuing without\n");
}
ret = cmd_el->set(command, data);
goto out;