From beb7c1741ee8f39a96d5fab6845f415b232d5fb4 Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Fri, 28 Apr 2023 17:33:36 +0200 Subject: Fix 'Fix parsing of TLV_TYPE_SINGLE_TV' A commit was merged recently attempting to fix decoding of TLV_TYPE_SINGLE_TV. It did mostly a good job, but missed updating the o_tag pointer used to fill in the structures. This commit fixes that specific part missing. Fixes: 559a6ee68359dab691a483573982e6f8c6439ae2 Change-Id: Id619459c17976b77cd2c7e4179123bb06807285c --- tests/tlv/tlv_test.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'tests/tlv/tlv_test.c') diff --git a/tests/tlv/tlv_test.c b/tests/tlv/tlv_test.c index aaa86a3a..8e8bd603 100644 --- a/tests/tlv/tlv_test.c +++ b/tests/tlv/tlv_test.c @@ -470,14 +470,12 @@ static void test_tlv_type_single_tv(void) rc = tlv_parse(&tp, &att_tlvdef, buf, sizeof(buf), 0, 0); OSMO_ASSERT(rc == 1); - OSMO_ASSERT(!TLVP_PRESENT(&tp, SAMPLE_SINGLE_TV_IE)); //FIXME! + OSMO_ASSERT(TLVP_PRESENT(&tp, SAMPLE_SINGLE_TV_IE)); val = TLVP_VAL(&tp, SAMPLE_SINGLE_TV_IE); - OSMO_ASSERT(!val); //FIXME! -#if 0 + OSMO_ASSERT(val); OSMO_ASSERT(val == &buf[0]); OSMO_ASSERT(*val == buf[0]); OSMO_ASSERT((*val & 0x0f) == exp_val); -#endif } int main(int argc, char **argv) -- cgit v1.2.3