aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-07-13gprs_ns2: ensure the NSE becomes dead when FR link went downAlexander Couzens3-0/+61
The FR code is using force unconfigured to change the state of the NSVC when the FR link goes down. The force unconfigured state didn't notified the NSE when changing into this state. Related: SYS#5533 Change-Id: I4d7bbbbce26f7cde99eebe96995c50b1e812e5bd
2021-07-09Aggregate NSVC stats inside the NSEDaniel Willmann4-13/+45
Change-Id: Ifa3c85ec52bda14596e9d7a8705baa1fd4ee2010 Related: OS#4998
2021-07-09fix api doc of osmo_identifier_sanitize_buf()Neels Hofmeyr1-1/+1
The implementation cleary replaces sep_chars instead of keeping them. Adjust the doc to clarify that. It seems to me that the intention was to *allow* sep_chars instead of replacing them, especially when looking at sep_chars of osmo_separated_identifiers_valid(). But we're stuck with that now. Change-Id: Ia842a7eeb46b49ee364be55c1194e463ebcaf392
2021-07-07linuxlist: add macro to get last element of a listPhilipp Maier1-0/+6
It is not be obvious on the first look that ->prev actually points to the last element of a list, lets add a macro for that to make the API easier to use Change-Id: Icf455bf6ba9d60bd311af17c9e80febaa42cacc9 Related: SYS#4971
2021-07-06gprs_ns2_vty: dump_nsvc: change output depending on NSVCIAlexander Couzens2-18/+17
If the NSVCI is valid, there is no signalling or data weight defined (internally this is 1). For NSVC with NSVCI don't print the signalling or data weight. For NSVC without NSVCI, don't print NSVCI at all. Related: OS#5180 Change-Id: Iaadc806a9136436468e2b02eb0bc1f4570a10ecc
2021-07-06gprs_ns2: fix wrong format string in Tx Size loglineAlexander Couzens1-1/+1
Don't use %u for integer. Change-Id: I324836ec4943c97f0dbc16ade697c468eba02b35
2021-07-06gprs_ns2: use gprs_ns2_free_bind() to clean up a bindAlexander Couzens2-3/+7
gprs_ns2_free_bind() takes care of all required steps to clean up a bind. The driver->free_bind() operation only cleans up the driver internal state but not NSVCs and other generic things. Fixes a crash when free'ing a bind from the vty which has active NSVCs. Related: OS#5195 Change-Id: I0a2ad22905bcacb929b9b5f5b034af0da3081826
2021-07-02gprs_ns2: correct mtu value in the log lineAlexander Couzens1-2/+2
The log line should describe what's reported towards the NS user and not the NSE MTU itself Related: OS#5192 Change-Id: I3f5445a1ba8c89c4023ff48be15a80569a128528
2021-07-02gprs_ns2: fix check of MTU changes for frame relayAlexander Couzens1-3/+7
The frame relay needs 2 byte for data packets. Related: OS#5192 Change-Id: I02d4e81896a473aeb79ea2f2983e12324244048f
2021-07-02gprs_ns2: fix crash when changing the MTUAlexander Couzens2-3/+12
When the MTU changes for any fr device, all NSE will recalculate their MTU. If any NSE is alive, libosmocore will crash. Related: OS#5192 Change-Id: I31ba5cefea7bbb0b74060d6664b42c58815ee2a1
2021-06-30bts_feature: Introduce feature to confiure dyn ts as sdcch8Pau Espin Pedrol2-0/+3
This feature signals support to configure Osmocom Dynamic Timeslot type as SDCCH8, on top of historically supported TCH/H and TCH/F. The idea is that when unneeded, the TS is configured as PDCH, and as soon as there's need for an SDCCH and there's none available, the TS is dynamically reconfigured to SDCCH8. Once all logical channels in the dynamic TS are released and hence becomes free, the BSC will reconfigure it to PDCH. Related: SYS#5309 Change-Id: Ifc0ca8916bd3e93e5a60a7dd7391d2588fdb5532
2021-06-30Rename osmo dyn ts enumsPau Espin Pedrol3-3/+7
They will gain support to be activated as SDCCH/8 soon too. Since new name would start to be too large, use a more generic naming for it. Related: OS#5309 Change-Id: I56dcfe4d17899630b17f80145c3ced72f1e91e68
2021-06-29add fixme: enforce 8 byte length of KcNeels Hofmeyr1-0/+4
Change-Id: I57efb0a24cb71b365189eccb5088b130fad15093
2021-06-29ns2: Ignore NSVC with data_weight 0 for datadaniel/miscDaniel Willmann1-0/+2
Change-Id: If0c2bee285f85110771326e07b513fc3e3f9d3f0 Fixes: OS#5189
2021-06-28cosmetic: gsm_12_21.h: Fix trailing whitespacePau Espin Pedrol1-2/+2
Change-Id: Ifdcdcfe30c41da233899101e1057bfca7d645a66
2021-06-25bts_features: add feature for BCCH carrier power reduction modeVadim Yanitskiy2-0/+3
Change-Id: I69283b3f35988fc7a1a1dcf1a1ad3b67f08ec716 Related: SYS#4919
2021-06-25gsm0808: add Kc128 to Handover RequestNeels Hofmeyr2-1/+9
Change-Id: Ieb6e43eef9e57281d54d4b7c63664668df5aef3e
2021-06-25gprs_ns2_vc_fsm: reset the ALIVE response time when stopping testAlexander Couzens1-0/+1
Prevent showing a response time when the NSVC has failed. Related: OS#5089 Change-Id: I5435077d35ff1ae3d743ea1b1b8ace7f0fb913cf
2021-06-25gprs_ns2: fix missing notify towards the NSE when NSVC become blockedAlexander Couzens3-0/+73
The NSE wasn't notified when a NSVC went into the BLOCKED state from an UNBLOCKED state. Related: OS#5182 Change-Id: I09634e414e9bb966e6b5809b7de1b59fbabd413d
2021-06-25gprs_ns2: use llist_add_tail to keep orderAlexander Couzens3-10/+10
When configuring multiple NSE/BINDs the order of the configuration should be keeped. Related: OS#5181 Change-Id: Ibbc03f0780b49543b5bd97ee059f11cfd6c2a126
2021-06-21add Kc128 to gsm0808 Create Ciphering CommandNeels Hofmeyr5-10/+73
Prepare for A5/4 support in osmo-msc. Add new function gsm0808_create_cipher2() which takes a struct as argument instead of individual fields. This is akin to e.g. gsm0808_create_handover_request() below in the file, and allows backwards compatibly extending the argument list without needing a new function signature every time. Add struct gsm0808_cipher_mode_command, as argument list for gsm0808_create_cipher2(), with kc128 included. Encode the Kc128 IE in gsm0808_create_cipher2(). Implement gsm0808_create_cipher() by calling gsm0808_create_cipher2(). Change-Id: Ib3906085e0c6e5a496a9f755f0f786238a86ca34
2021-06-18vty: make function cmd_range_match() publicPhilipp Maier2-4/+6
Certain control interface commands also may require to verfy a range in their verify function. cmd_range_match() from the VTY does exactly that and the range can be specified as string, the same way as we would specify it in the VTY. Change-Id: I53fc207677f52b1dc748b01d58424839cdba807c related: SYS#5369
2021-06-18osmo_select_shutdown_request(): allow finishing pending writes on SIGTERMNeels Hofmeyr2-1/+72
Allow telling osmo_select_main* to only service pending writes (shutdown mode). Introduce API fuctions to indicate a shutdown request, and find out whether shutdown is complete. Some osmo programs have a curious sleep of few seconds upon receiving SIGTERM. The idea presumably was to finish off pending writes before halting the program. But a sleep() on program exit is annoying, especially when there usually are no pending writes, and when osmo-bsc is launched numerous times for tests. Change-Id: Ib94d4316924103459577087c2214188679db2227
2021-06-16stats_vty: Improve generation of osmo countersDaniel Willmann1-11/+10
Use section for all counter headings, the idea is that the generated doc is included below a chapter describing the implemented counters which can optionally describe individual items. If not osmo_counters are present simply omit the whole section to tidy up the manual. Those are deprecated anyway and not used in the osmo-* projects that I checked. Change-Id: I126b39cb9458e0f62efa338967e07151a0eece0f Related: SYS#5005, OS#4523
2021-06-16control_cmd: fix typoPhilipp Maier1-1/+1
Change-Id: I9deaee42aeb0ab0549cc7c4f180ad9c216b9df39
2021-06-15ctrl: Support recovering from short writePau Espin Pedrol1-1/+7
osmo_wqueue has support for it, so simply handle it correctly in the callback (updating buffer and returning -EAGAIN). Related: OS#5169 Change-Id: I6cbc7ec6ae6832e61cddf4402332ba09b142a7d4
2021-06-15ctrl: Pre-calculate required size before allocating msgbPau Espin Pedrol2-62/+34
This commit fixes crash when response is more than ~4096 chars. Furthermore, we now allocate only the required memory, not 4096 for all messages, which usually don't require it. Test needs to be adapted since it assumed there was more available space at the end of the msgb. Related: OS#5169 Change-Id: I0b8f370f7b08736207f9efed13a0663b5e482824
2021-06-13gprs_ns2_sns: bss: set gss->familyAlexander Couzens1-0/+1
gss->family (and gss->ip) was never set. So IPv6 should have never worked. Fixes: e769f5226be6 ("gprs_ns2_sns: rework IP-SNS initial remote") Related: OS#5036 Change-Id: I4e39dc5c7f766a7040645ceb62afdf6a9cfad00f
2021-06-13gprs_ns2_sns: replace ns2_sns_type with address familyAlexander Couzens1-28/+24
Reduces the code as the conversion between address family (bind) and ns2_sns_type is not needed anymore. Related: OS#5036 Change-Id: I1bcdd43af34c926d4b88491d00669422c299bef7
2021-06-13gprs_ns2_sns: refactor nss_weight_sum_data -> ip46_weight_sum_dataAlexander Couzens1-7/+7
Allow to use ip46_weight_sum_data for local endpoints as well. Related: OS#5036 Change-Id: I75d88f3da89ad13e34a3fd5ae72bd967d81f4abc
2021-06-13gprs_ns2_sns: refactor ip4_weight_sum/ip6_weight_sumAlexander Couzens1-16/+14
Use the new introduced struct ns2_sns_elems instead of the elems seperate. Related: OS#5036 Change-Id: I0956ab6085554210569188f52cae121e32fca19b
2021-06-13gprs_ns2_sns: add check for duplicates to add_ip6_elem()Alexander Couzens1-3/+8
The ip4 version already checks for duplicates. Related: OS#5036 Change-Id: I4a1528ea3427946ce465085919b2b522d3cedd07
2021-06-13msgb_alloc_headroom: Change size args to be uint16_tPau Espin Pedrol1-2/+2
Underlaying APIs (msgb_alloc) use a uint16_t as a type, which means until now passing a value > 2^16 would succeed providing a msgb with less space than requested. Since those are static inline, there's no symbols used by apps, so we should be safe enough changing the type to be uint16_t, since change would only be applied at re-compile time. Change-Id: I83c8222484e4856c68134a1a9d8cf96eb91af1b8
2021-06-11bts_feature: Introduce feature to speak to PCUPau Espin Pedrol2-0/+3
This feature provides the BSC with information on whether the BTS talks the IPAC_PROTO_EXT_PCU osmocom extension over the underlying IPA multiplex of the OML link. Related: SYS#5303 Change-Id: Id62421f7f5540875ac877a187757f2cf0556bd02
2021-06-11ipaccess: Add new osmo extension IPAC_PROTO_EXT_PCUPau Espin Pedrol1-0/+1
This new extension protocol is used to forward Osmocom PCUIF messages BSC<->BTS<->PCU. It will be sent re-using the IPA multiplex of the OML link between BSC and BTS. BTS is responsible for forwarding the message over the unix socket to the PCU. Related: SYS#5303 Change-Id: I68b04def49946b6915dbd4e476999f249751cd28
2021-06-10ns2: use same name in ctr_group as stat_item_groupMichael Iedema1-0/+1
Change-Id: I7d2dcb6c7ddf72a0d06ff19f5d0e3dc740bd19ff
2021-06-08kdf: add key derivation functionsEric16-1/+1752
generic sha code from git://w1.fi/hostap.git commit 5ea93947ca67ba83529798b806a15b247cdb2e93 which also happens to be the source of our milenage code. Related: SYS#5324 Change-Id: Ibf2e49edada944d91ceba62bd0d6b6ce69261fcd
2021-06-07stats_vty: also show rate counter group name (if present)Vadim Yanitskiy1-1/+4
Change-Id: I358f52e81a85f041fc21960634d04d18e7883dd5
2021-06-07gprs_ns2_sns: move gss->remote specific check out of add_ip4_elem/add_ip6_elemAlexander Couzens1-8/+8
Allow to use the add_ip4_elem also with local elemens. Related: OS#5036 Change-Id: Ib48dfd7567467e60c5af2348924ece5cc6124206
2021-06-07gprs_ns2_sns: use struct ns2_sns_elems in add/update/remove remote_elemsAlexander Couzens1-41/+47
Prepare to use the function also with local elems. Related: OS#5036 Change-Id: I7db43c8dbd5bd7e7b07a7d629d2615bfa18623db
2021-06-07gprs_ns2_sns: refactor ns2_clear_ipv46_entries_local to use new elems functionsAlexander Couzens1-19/+10
Related: OS#5036 Change-Id: I7225f7a4215842f0ea601ce6d9d38220f98f808d
2021-06-07gprs_ns2_sns: refactor local and remote entries into a structAlexander Couzens1-105/+102
The IPv4/IPv6 elemens are the same for local and remote. Refactor the entries into a struct to use function to manipulate them with a single function. Related: OS#5036 Change-Id: I05e053a9eb3328655502dfe2981c8f402104e292
2021-06-07gprs_ns2_sns: bss: improve validation of configurationAlexander Couzens1-1/+49
Some combination of IPv4 and IPv6 result in incomplete combination. E.g. IPv6 binds, but only IPv4 endpoints and vice versa. Related: OS#5036 Change-Id: I2fcf67bc2431ddac23c4ae23cebbb29771e573f1
2021-06-07gprs_ns2_sns: move selection of the next bind into own functionAlexander Couzens1-12/+10
It will be also used by del_bind() when removing an active bind Related: OS#5036 Change-Id: Ic39f0e5474ecc055d9a1b6a7b30777574d8b741d
2021-06-05ns2: Use NSVC bufid in stats reportPau Espin Pedrol1-0/+2
Use the new stats API to set a meaningful name for its stats group too, so that they are easily to identify when reported. Example on VTY "show stats": """ NSVC Peer Statistics (0)('UDP-NSE01800-NSVC01800'): ALIVE response time : 0 ms NS Bind Statistics: Transmit backlog length: 0 packets """ Example reporting to statsd: """ my-stats-reporter-prefix.ns.nsvc.UDP-NSE01800-NSVC01800.alive.delay:0|g """ Related: SYS#5456 Change-Id: I4c696c615ba3416f8524d0797ce06c0ecd3a18f2
2021-06-05stat,rate_ctr: Allow setting group name and use it at report timePau Espin Pedrol7-35/+67
This patch adds a new field "name" to the rate_ctr and osmo_stat_item_group structs, together with an API to set it. This new field allows for easy identification of specific group instances when several of them exists, rather than using a sometimes random/increasing index value. If set, this name (string) is used instead of the index by the stats reporter. The name, if set, is also printed during "show stats" VTY commands. It's up to the user or application to set up unique or meaningful names to fullfill one's needs. WARNING: this commit breaks ABI and possibly creates unexpected behavior when run with non-rebuilt apps which use the modified structs directly to get the coutners, or if use the static inline API rate_ctr_inc2(). Existing users of these structs should migrate to use new APIs introduced in follow-up commits instead of accessing the field directly. Related: SYS#5456 Change-Id: I0dc510783dd9ae8436dae8005a7b3330e80d36f3
2021-06-05gprs_ns2: rework id strings of nsvcsAlexander Couzens3-11/+19
Ensure all nsvcs ids are unique as UDP ids might not be unique when multiple NSVCs connect to the same remote endpoint (multiple binds). Change the format of all ids to look similiar. FR: NSE11-NSVC23-FR-fr0-DLCI13. UDP: NSE11-NSVC-UDP-10.0.0.1:23000-192.168.1.1:24000 UDP: NSE11-NSVC23-UDP-10.0.0.1:23000-192.168.1.1:24000 UDP: NSE11-NSVC66-UDP-[fd01::1]:23000-[fd03::2]:24000 Change-Id: I618e263e73fcc64d4e46b57aa3a2cb2783837907
2021-06-04fsm: cosmetic: fix weird spacing in osmo_fsm_inst_alloc()Vadim Yanitskiy1-2/+2
Change-Id: I199085e717c6ebdc9061a0c9fa9a96bfbc11a74a
2021-06-04Use new stat item/ctr getter APIsPau Espin Pedrol10-93/+93
Generated with spatch: """ @@ expression E1, E2; @@ - &E2->ctr[E1] + rate_ctr_group_get_ctr(E2, E1) """ """ @@ expression E1, E2, E3; @@ - E2->items[E1] + osmo_stat_item_group_get_item(E2, E1) """ Change-Id: I41297a8df68e28dfc6016330ac82b0ed5dd0ebc1
2021-06-03gsm_08_58.h: add mask for Osmocom specific VAMOS C-bitsVadim Yanitskiy1-0/+1
Applying and reverting this mask allows one to quickly convert between VAMOS and non-VAMOS variants of Bm/Lm C-bits. Change-Id: Ia0bd8695a3f12331b696fe69117189cdd48b584d Related: SYS#4895, OS#4941, SYS#5315, OS#4940
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-22 18:51:43 +0000