aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2013-03-13Add smpp34_osmocom.h for Osmocom SMPP vendor additions0.6.0Harald Welte2-0/+49
2013-03-13gsm_septets2octets(): Input parameter should be constHarald Welte2-2/+3
2013-03-13logging_vty: Print 'log filter all' info in 'show logging vty'Harald Welte1-0/+6
When we print information about the current logging configuration, it makes sense to also print information about the log filters.
2013-03-09utils: Introduce OSMO_ASSERT in the utils and use it in the unit testsKaterina Barone-Adesi4-98/+100
The tests should unconditionally assert, regardless of debug settings. This uses the OSMO_ prefix as it's in the global namespace.
2013-03-03cygwin: Link many libraries with -no-undefined to create a dllHolger Hans Peter Freyther4-5/+5
Only the Gb library relies on having undefined references to a symbol that needs to be provided by the host application. For all other libraries we can link with -no-undefined.
2013-03-01codec: Fix the GSM 06.20 ordering tablesSylvain Munaut1-41/+41
Seems the script I used to parse those had a bug where range of bits in the 'decreasing' direction ( like 6..0 ) were not processed properly. Thanks to Andreas for noticing this ! Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2013-02-27Follow up fix for the log level "everything"Holger Hans Peter Freyther1-0/+3
Commit cd6ed82d1ff48f47ad9e33e6322df62896a76ed5 made "EVERYTHING" map to LOGL_DEBUG but when writing out the configuration the following would be written: logging level all unknown 0x0 This happend because no string was found for the value 0. Address it by adding a legacy check for 0 and write out the str from the index 0. Currently this is "EVERYTHING".
2013-02-27Added a ring buffer log target to store the last N log messages.Katerina Barone-Adesi16-8/+796
The log target can be used via log alarms and show alarms. Why? This feature was proposed/requested at http://openbsc.osmocom.org/trac/wiki/Tasks/ErrorLogTarget All messages use the same amount of space, prioritizing simplicity.
2013-02-27Revert "Added a ring buffer log target to store the last N log messages."Holger Hans Peter Freyther15-792/+8
I noticed some more issues and it is the easiest to revert and include the fixed version. This reverts commit 73377229bb33ab79682ce4b126a63602d13304ad.
2013-02-27Added a ring buffer log target to store the last N log messages.Katerina Barone-Adesi15-8/+792
The log target can be used via log alarms and show alarms. Why? This feature was proposed/requested at http://openbsc.osmocom.org/trac/wiki/Tasks/ErrorLogTarget All messages use the same amount of space, prioritizing simplicity.
2013-02-21Add UMTS RRC message typesTobias Engel1-0/+68
2013-02-19Fix log level "everything" and make it equal to "debug"Harald Welte1-1/+1
As Holger points out "logging level XXX everything" wasn't working, as it sets category->loglevel to 0, which is checked in osmo_vlogp() and will never get logged.
2013-02-15misc: Doxygen tweaks: fixed some typos and minor errorsKaterina Barone-Adesi26-38/+45
Doxygen generates quite a lot of warnings on libosmocore. Some of them are obvious typos - this patch aims to fix such low-hanging fruit.
2013-02-13debian: Re-enable the debug packagesHolger Hans Peter Freyther5-13/+11
Remove the .dirs/.install as things will go wrong then. debhelper will try to install the debug symbols before they were created. Thanks to Jan for pointing that out.
2013-02-13debian: Update the change log for a new packageHolger Hans Peter Freyther1-2/+3
2013-02-12VTY: don't show HIDDEN or DEPRECATED vty commands in ? completionHarald Welte1-0/+3
This hides HIDDEN or DEPRECATED commands from showing up when the full list of commands is inquired with '?' at any given point in the command tree. Only if the hidden/deprecated command is already typed in partially, then it will still tab-complete.
2013-02-12vty/command.c: Cosmetic cleanupHarald Welte1-82/+81
this is just changing some of the code to reduce the way too high level of indentation and thus improve readability.
2013-02-10abis_nm: add parenthesis for new abis_nm_debugp_foh() macroHarald Welte1-3/+3
without this, we break e.g. the openbsc build...
2013-02-10turn abis_nm_debugp_foh() into a macroHarald Welte2-13/+21
this will avoid printing 'abis_nm.c' as the filename in the log, which is pretty useless during debugging. We want to know where abis_nm_debugp_foh() is being used from, not where it is implemented.
2013-02-08doc: Fix typo in Doxyfile.core.in causing sources to be ignoredSylvain Munaut1-1/+1
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2013-02-01core/crc: Fix the 64 bits implementationSylvain Munaut1-2/+2
We used 1ULL at one place and not the other ... at the same time, we now use (uintXX_t) so that the proper type is used each time. Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2013-01-15fr_test: Speculative build fix for FreeBSDHolger Hans Peter Freyther1-0/+3
2013-01-15fr: Begin with a GRE/FrameRelay test due the recent regressionHolger Hans Peter Freyther6-2/+93
The framerelay code is seldomly used and the socket clean ups introduced a regression. Create a testcase that will work as a user not having the right capabilities to create raw sockets. We have to make sure that this test is working even when not ran as root. The easiest way to do this is to provide our own socket implementation. This is done with dlopen/dlsym to convert the raw socket request to an UDP one.
2013-01-15socket: fix osmo_sock_init with SOCK_RAW and IPPROTO_RAWPablo Neira Ayuso1-3/+16
getaddrinfo returns EAI_SERVICE (-8) if that combination is used. More information available in here: http://sourceware.org/bugzilla/show_bug.cgi?id=15015 Reported by Holger Hans Peter Freyther. While at it, this patch also removes hints.ai_flags = 0 as memset to zero already happened just a bit before that.
2013-01-12Fix build on CygwinEvgeny Zverev1-1/+5
2013-01-11add some missing doxygen annotation for libosmocore functionsHarald Welte7-11/+75
2013-01-06doxyfiles: refer paths to @srcdir@Alex Badea4-4/+4
When building out-of-srcdir, paths such as "src/gsm" will not find any source files. Since the Doxyfiles are preprocessed, we can prepend @srcdir@ to fix that. Signed-off-by: Alex Badea <vamposdecampos@gmail.com>
2013-01-06tests/timer: tweak path to config.hAlex Badea1-1/+1
When building out-of-srcdir, "../../config.h" fails to reach config.h because the compiler is invoked in $builddir/tests/, not $builddir/tests/timer/. Use "../config.h" instead; this also works for in-srcdir builds. Signed-off-by: Alex Badea <vamposdecampos@gmail.com>
2013-01-06Replace obsolete automake AM_CONFIG_HEADER.Christian Vogel1-1/+1
This fixes the following complaint by autoconf 2.69-1, automake 1.13.1-1. : configure.ac:80: error: 'AM_CONFIG_HEADER': this macro is obsolete. : You should use the 'AC_CONFIG_HEADERS' macro instead. : /usr/share/aclocal-1.13/obsolete-err.m4:12: AM_CONFIG_HEADER is expan : configure.ac:80: the top level Automake 1:1.11.3-1ubuntu2, autoconf 2.68-1ubuntu2 don't even emit a warning without, and work just fine with this patch. Signed-off-by: Christian Vogel <vogelchr@vogel.cx>
2013-01-04debian: Bump the changelog and package osmo-arfcnHolger Hans Peter Freyther4-0/+16
2013-01-03vty: Do better filtering of arguments, optional args particularlySylvain Munaut1-208/+143
This is essentially http://patchwork.diac24.net/patch/271/ forward ported to libosmovty Original-by: Paul Jakma <paul@quagga.net> Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2013-01-03core/bits: Prevent osmo_revbytebits_buf stack trashingSylvain Munaut1-1/+1
The second loop in osmo_revbytebits_buf() in src/bits.c grabs 4 bytes each iteration, which can easily go past the supplied input in some cases. Compiled with -fstack-protector , I get a "stack smashing detected" in the bits test. From: Nils O. Selåsdal <noselasd@fiane.dyndns.org> Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2012-12-26tests: Don't delete atconfig in cleanDaniel Willmann1-1/+2
This file is created in ./configure so we shouldn't remove it with make. Otherwise ./configure && make clean && make check fails with: make[3]: *** No rule to make target `atconfig', needed by `check-local'. Stop.
2012-12-26lapd: Fix compiler warnings in the lapd codeHolger Hans Peter Freyther1-0/+2
lapd_test.c: In function ‘ms_to_bts_l1_cb’: lapd_test.c:192:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] lapd_test.c:199:1: warning: no return statement in function returning non-void [-Wreturn-type] lapd_test.c: In function ‘main’: lapd_test.c:355:2: warning: implicit declaration of function ‘osmo_init_logging’ [-Wimplicit-function-declaration]
2012-12-26lapd: Check in rslms_rx_rll() if lapdm context was initialized earlierDaniel Willmann3-2/+62
This was found while implementing handover on a sysmobts. When we receive a channel release request for a channel that was never really activated (set_lapdm_context() was not called) we segfault in lapd_recv_dlsap(). We now return early with -EINVAL in rslms_rx_rll() if we receive a message that assumes set_lapdm_context() was already called. These are: * RSL_MT_UNIT_DATA_REQ * RSL_MT_DATA_REQ * RSL_MT_SUSP_REQ * RSL_MT_REL_REQ A test case was added to trigger the issue.
2012-12-18Add tlvp_val16_unal() / tlvp_val32_unal() to align 16 and 32 bit valuesAndreas Eversberg1-0/+24
This is required for CPUs < armv6, to access 16 and 32 values at right memory locations.
2012-12-12core: Fix missing include in msgfile.c for getlineSylvain Munaut1-0/+1
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2012-12-11build: Don't use the deprecated INCLUDES in the various Makefile.amSylvain Munaut7-12/+8
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2012-12-11utils/osmo-arfcn: Implement option to get ARFCN from frequencySylvain Munaut1-1/+32
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2012-12-11gsm: Add method to find ARFCN based on frequencySylvain Munaut3-45/+69
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2012-12-06osmo-arfcn: add support for PCS bandHarald Welte1-6/+13
2012-12-06rsl: Add the 9.3.20 release mode enum to be used in OpenBSCHolger Hans Peter Freyther1-0/+6
2012-12-06sms: Print 'network' or 'mobile' when creating the SMC/SMRHolger Hans Peter Freyther2-3/+4
2012-12-06gsm/a5: Return -ENOTSUP if the selected cipher is not supportedSylvain Munaut2-3/+7
Extracted from a patch by Max Suraev Max.Suraev@fairwaves.ru> Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2012-11-26lapd: Use LOGL_ERROR for messgaes that are wrong in the given contextHolger Hans Peter Freyther1-14/+14
Log message that are either too big or have the C/R bit set as error.
2012-11-22misc: Use static const struct for LAPD and AbisHolger Hans Peter Freyther2-2/+2
2012-11-22sms: Mark the state dispatch table as static constHolger Hans Peter Freyther2-4/+4
GCC 4.7.2 was already smart enough to see that the table is const so there is no change in the generated assembly code. For some reason the dispatch is still going through one relocation.
2012-11-22sms: Fix typos in the comments and log messages.Holger Hans Peter Freyther2-5/+5
2012-11-22smr: Introduce an id and prefix all log messages with SMR(ID)Holger Hans Peter Freyther2-32/+70
When OpenBSC is handling more than one message at a time it is difficult to see which log message belongs to which SMR instance. Introduce a uint64_t id that can be set to the row_id/message_id and prefix all log messages with SMR(ID). This change is ABI and API incompatible with previous versions of libosmogsm.
2012-11-22smc: Introduce an id and prefix all log messages with SMC(ID)Holger Hans Peter Freyther2-31/+62
When OpenBSC is handling more than one message at a time it is difficult to see which log message belongs to which SMC. Introduce a uint64_t id that can be set to the row_id/message_id and prefix all log messages with SMC(ID). This change is ABI and API incompatible with previous versions of libosmogsm. Example: SMC(100) instance created SMC(100) message MNSMS-EST-REQ received in state IDLE