path: root/tests/bitvec/bitvec_test.c
diff options
authorHolger Hans Peter Freyther <holger@moiji-mobile.com>2016-01-30 10:54:43 +0100
committerHolger Hans Peter Freyther <holger@moiji-mobile.com>2016-01-30 10:54:43 +0100
commita9301a1a1f2ac0c73aff2075c2361d54a6fc8675 (patch)
treef12b465a403dc925bb279f138784594ae92ce1c7 /tests/bitvec/bitvec_test.c
parent912bc6ff5047f08bb55c1d08be5fe4485e37e5d6 (diff)
bitvec: Test and fix regression for C++->C conversion
bitvec_read_field/bitvec_write_field in the PCU used a C++ reference and when porting to C it was decided to pass the parameter by value and this lost the "back propagation" of the new index. Change the parameter to be an in/out parameter and this way do not have a silent semantic break in the osmo-pcu (where we copy the reference in csn.1 by value) and have a true compile failure. Add Max's simple test for bitvec_unhex function leaving the checking of bitvec_read_field and the side effect in the datastructure about the number of bits still open.
Diffstat (limited to 'tests/bitvec/bitvec_test.c')
1 files changed, 16 insertions, 0 deletions
diff --git a/tests/bitvec/bitvec_test.c b/tests/bitvec/bitvec_test.c
index 624e3346..789df75a 100644
--- a/tests/bitvec/bitvec_test.c
+++ b/tests/bitvec/bitvec_test.c
@@ -55,8 +55,24 @@ static void test_byte_ops()
printf("=== end %s ===\n", __func__);
+static void test_unhex(const char *hex)
+ struct bitvec b;
+ uint8_t d[64] = {0};
+ b.data = d;
+ b.data_len = sizeof(d);
+ b.cur_bit = 0;
+ printf("%d -=>\n", bitvec_unhex(&b, hex));
+ printf("%s\n%s\n", osmo_hexdump_nospc(d, 64), osmo_hexdump_nospc((const unsigned char *)hex, 23));
int main(int argc, char **argv)
+ test_unhex("48282407a6a074227201000b2b2b2b2b2b2b2b2b2b2b2b");
+ test_unhex("47240c00400000000000000079eb2ac9402b2b2b2b2b2b");
+ test_unhex("47283c367513ba333004242b2b2b2b2b2b2b2b2b2b2b2b");
+ test_unhex("DEADFACE000000000000000000000000000000BEEFFEED");
return 0;