exec: propogate errors from osmo_environment_[filter|append]

Change-Id: If7d6e0441f73092a4fb455340c076ba4dc60af3f

1 files changed, 10 insertions, 4 deletions

diff --git a/src/exec.c b/src/exec.c
index b806ad56..62f59194 100644
--- a/src/exec.c
+++ b/src/exec.c
@@ -221,10 +221,16 @@ int osmo_system_nowait(const char *command, const char **env_whitelist, char **a
 		new_env[0] = NULL;
 
 		/* build the new environment */
-		if (env_whitelist)
-			osmo_environment_filter(new_env, ARRAY_SIZE(new_env), environ, env_whitelist);
-		if (addl_env)
-			osmo_environment_append(new_env, ARRAY_SIZE(new_env), addl_env);
+		if (env_whitelist) {
+			rc = osmo_environment_filter(new_env, ARRAY_SIZE(new_env), environ, env_whitelist);
+			if (rc < 0)
+				return rc;
+		}
+		if (addl_env) {
+			rc = osmo_environment_append(new_env, ARRAY_SIZE(new_env), addl_env);
+			if (rc < 0)
+				return rc;
+		}
 
 		/* if we want to behave like system(3), we must go via the shell */
 		execle("/bin/sh", "sh", "-c", command, (char *) NULL, new_env);